Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newrelic.sh doesn't run with Python3.7 #27

Open
aweakley opened this issue Aug 7, 2020 · 3 comments
Open

newrelic.sh doesn't run with Python3.7 #27

aweakley opened this issue Aug 7, 2020 · 3 comments

Comments

@aweakley
Copy link
Member

aweakley commented Aug 7, 2020

I had to upgrade to a newer NewRelic. It was this issue: https://discuss.newrelic.com/t/async-and-await-will-be-reserved-keywords-in-python-3-7/53297

I ended up with newrelic==5.14.1.144 but it appears to work with anything >=2.100.0.84

@jmurty
Copy link
Contributor

jmurty commented Aug 7, 2020

From Slack:

I think that I should put the minimum version in https://github.com/ixc/ixc-django-docker/blob/master/setup.py
Should I just go with the earliest-working version, or a more recent one?

@jmurty
Copy link
Contributor

jmurty commented Aug 7, 2020

@aweakley I think it would be reasonable to set a minimum version in ixc-django-docker's setup.py to force installation of more up-to-date versions, though it is arguably the project's responsibility to pin (and then update) its version of the new relic lib to be appropriate for the Python version the project is using.

@jmurty
Copy link
Contributor

jmurty commented Aug 7, 2020

Also, since any projects that are using very outdated versions of the newrelic library aren't likely to be using an up-to-date version of ixc-django-docker anyway, enforcing a minimum version here isn't likely to avoid the problem in any existing projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants