Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location of configuration files #73

Open
cristobaltapia opened this issue Aug 1, 2019 · 5 comments
Open

Location of configuration files #73

cristobaltapia opened this issue Aug 1, 2019 · 5 comments

Comments

@cristobaltapia
Copy link
Contributor

Hi, thanks for keep making improvements to this nice library!

As far as I understand the default location for the configuration files is ~/.dpapp (in Linux at least, introduced in 27626c8). However, in the Readme file, when describing how to use dptmount, the impression is given that the default folder is ~/.config/dpt (which I actually kind of like more, but that is another issue :P ). I think that this should be consistent and: (a) either change the path shown in the Readme file or (b) change the default location for the configuration files.

@janten
Copy link
Owner

janten commented Aug 2, 2019

You are right, this should be harmonized. Could you do a PR for this?

@cristobaltapia
Copy link
Contributor Author

cristobaltapia commented Aug 2, 2019 via email

@janten
Copy link
Owner

janten commented Aug 2, 2019

To me it would be fine either way. Ideally both scripts should try to read from both locations or at least migrate automatically to a common path, which should be documented in the Readme. Which path you choose as the new default is up to you.

@cristobaltapia
Copy link
Contributor Author

cristobaltapia commented Aug 3, 2019 via email

vico added a commit to vico/dpt-rp1-py that referenced this issue Dec 23, 2021
@vico
Copy link
Contributor

vico commented Dec 23, 2021

@cristobaltapia @janten if you don't mind, I created a PR here. There is no backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants