Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options page to edit the actual object we get back from './objects.js' #3

Open
jaywick opened this issue May 17, 2018 · 2 comments
Open
Labels
feature-request New feature or request

Comments

@jaywick
Copy link
Owner

jaywick commented May 17, 2018

No description provided.

@jaywick jaywick changed the title Colour options Options page to edit the actual object we get back from './objects.js' Jun 19, 2018
@jaywick jaywick added the feature-request New feature or request label Apr 5, 2020
@ziyadss
Copy link

ziyadss commented Jun 28, 2022

Hello!
Do you want help with this?

I've been using the extension for years (thank you for it!) and used it as a playground of sorts for a while, and pushed some of that to a fork I had today since I'm switching devices. There's some work which can be built on for a decent options page.

Since I had other changes in my personal copy, I quickly put together some hacky integration of the options page (everything in script.js into a function, called when the stored options get loaded) to your upstream, master...ziyadss:hello-friend:options-to-upstream

It's missing input validations, and the input areas for the two array members aren't user-friendly, but they work.

Two other notes:

  • Updated manifest_version to v3 since v2 is deprecated and will no longer work next year.
  • ROOT_FOLDER stored as a string since chrome.storage does not support objects with functions (RegExp.test() being the culprit here), with the pattern object being instantiated in script.js

image

@jaywick
Copy link
Owner Author

jaywick commented Jul 4, 2022

Hey @ziyadss! This looks awesome and glad to know you've found the extension useful 😀
Thank you for offering to contribute, I haven't looked thoroughly at the code yet but from the screenshot and your description it sound awesome. I'll make a PR to merge back upstream at some point (a little busy with work and life so might take a while 🙏)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants