Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match URL with query string #65

Open
jjoseba opened this issue Jun 10, 2020 · 0 comments
Open

Match URL with query string #65

jjoseba opened this issue Jun 10, 2020 · 0 comments

Comments

@jjoseba
Copy link

jjoseba commented Jun 10, 2020

Currently, if a MenuItem receives a URL with query params, since the url match is done against the request.path, there is no way for that item to be checked as active.

For example, if I configure this item:

Menu.add_item("main", MenuItem(_("Item"), reverse('app:my_view')+'?status=active', weight=10))

That item will not be marked as the active item. Maybe MenuItem() could receive an additional argument to be able to take into account the current queryparam for the match_url() method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant