-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using pip-compile with --build-deps-for or --all-build-deps gives error when using multiple source files. #2076
Comments
Yeah, I don't remember what our stance on that was... However, combining multiple different envs tends to over-complicate things so I'm an advocate of doing the opposite. Still, it was designed to lock one's package's build deps, not build deps of every single package in the tree. It'd be ambiguous which project you want the build deps to be retrieved from, if there's many. Plus, it's not uncommon that several projects in the tree have conflicting build dep restrictions (and each of those projects is built in isolation). |
Is your concern for a command like My use case is that I don't want to keep extra dependencies in As far as I can tell (Edit: see added test), a command of the form Would allowing only one setup file in the sources list satisfy your concern? |
I once wanted to combine the deps into the same lockfile but later I changed my mind because it causes more problems than it solves: #1326 (comment). That test case does not cover the situation when the build dependencies of |
Using
pip-compile --all-build-deps requirments.in pyproject.toml
gives the error--build-deps-for and --all-build-deps can be used only with the setup.py, setup.cfg and pyproject.toml specs.
.According to the help, using multiple source files is valid, so any options that apply to at least one source file should be allowed as long as that option does not cause a conflict.
Environment Versions
Steps to replicate
pip-compile --all-build-deps requirments.in pyproject.toml
Expected result
No error.
Actual result
--build-deps-for and --all-build-deps can be used only with the setup.py, setup.cfg and pyproject.toml specs.
The text was updated successfully, but these errors were encountered: