Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why are there full viewport updates? #431

Open
JamesDeAntonis opened this issue Sep 5, 2024 · 1 comment
Open

Why are there full viewport updates? #431

JamesDeAntonis opened this issue Sep 5, 2024 · 1 comment

Comments

@JamesDeAntonis
Copy link

I noticed here that you have

self.setViewportUpdateMode(QtWidgets.QGraphicsView.FullViewportUpdate)

is it dangerous to set bounding rect viewport update instead?

self.setViewportUpdateMode(QtWidgets.QGraphicsView.BoundingRectViewportUpdate)

When dragging nodes, I noticed the full updates cause like 70 (I think) unnecessary repaints on top of the expected path repaints. This was causing lagginess for me, especially when other animations are happening at the same time
jchanvfx added a commit that referenced this issue Oct 6, 2024
@jchanvfx
changed update mode suggestion from @JamesDeAntonis #431
4b8a491
@jchanvfx
Copy link
Owner

jchanvfx commented Oct 6, 2024

Thanks for catching the issue I'll make an update 😃.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jchanvfx @JamesDeAntonis