Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support newer version of Jasmine #589

Open
mathieujobin opened this issue Mar 12, 2021 · 0 comments
Open

Support newer version of Jasmine #589

mathieujobin opened this issue Mar 12, 2021 · 0 comments
Labels

Comments

@mathieujobin
Copy link
Collaborator

mathieujobin commented Mar 12, 2021

For versions of jasmine 3.x

I am not going to merge anything just yet
but I have created branches with almost every 3.x releases

just use the correct branch in your gemfile.

gem 'teaspoon', github: 'jejacks0n/teaspoon'
gem 'teaspoon-jasmine', github: 'jejacks0n/teaspoon', branch: 'teaspoon-jasmine-3.6.0'

Please report any problems, ideally with working fixes ;)

For the future person doing this in the future.
I edit teaspoon-jasmine/lib/teaspoon/jasmine/framework.rb and teaspoon-jasmine/lib/teaspoon/jasmine/version.rb
And then I run

vv=3.3.0; git add -u ; git add teaspoon-jasmine/lib/teaspoon/jasmine/assets/jasmine/${vv}.js ; git checkout -b teaspoon-jasmine-$vv  ; git commit -m "Add jasmine $vv"; git push -u jejacks0n teaspoon-jasmine-$vv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant