You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I suggest removing data classes from the public API. If any of those classes still require equals, hashCode and toString implementations the Poko compiler plugin can generate those by adding a simple annotation to classes that require it.
I would be happy to work on a PR for this but given it would be a breaking change I'm not sure if this should be parked until a possible v2 release or if it could be done as part of v1.6.
The text was updated successfully, but these errors were encountered:
This is definitely something to consider changing in a future release, and I have thought about it before. Fortunately, we have our own code generator so we can extend that to generate the hashCode/toString functions. The only problem will be in the copy function where we can't keep compatibility.
I noticed that the API makes liberal use of Kotlin data classes. This is discouraged for libraries:
I suggest removing data classes from the public API. If any of those classes still require equals, hashCode and toString implementations the Poko compiler plugin can generate those by adding a simple annotation to classes that require it.
I would be happy to work on a PR for this but given it would be a breaking change I'm not sure if this should be parked until a possible v2 release or if it could be done as part of v1.6.
The text was updated successfully, but these errors were encountered: