From d33686169390d9aeb5085b6b13a1b4ec7d4427e0 Mon Sep 17 00:00:00 2001 From: sa103736 Date: Thu, 17 Oct 2024 14:32:59 -0400 Subject: [PATCH 1/2] Adding a FINE level log message when effectively triggering --- src/main/java/org/jenkinsci/plugins/gwt/Renderer.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/main/java/org/jenkinsci/plugins/gwt/Renderer.java b/src/main/java/org/jenkinsci/plugins/gwt/Renderer.java index 2b96db2..009948b 100644 --- a/src/main/java/org/jenkinsci/plugins/gwt/Renderer.java +++ b/src/main/java/org/jenkinsci/plugins/gwt/Renderer.java @@ -35,6 +35,14 @@ public static boolean isMatching(final String renderedRegexpFilterText, final St + "\" not matching \"" + renderedRegexpFilterText + "\"."); + }else{ + LOGGER.log( + FINE, + "Triggering \"" + + regexpFilterExpression + + "\" matching \"" + + renderedRegexpFilterText + + "\"."); } return isMatching; } From 3e12f99cc37ddb431dd6f7217390876b7457b8f5 Mon Sep 17 00:00:00 2001 From: Tomas Bjerre Date: Thu, 17 Oct 2024 20:50:35 +0200 Subject: [PATCH 2/2] chore: formatting --- .../java/org/jenkinsci/plugins/gwt/Renderer.java | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/main/java/org/jenkinsci/plugins/gwt/Renderer.java b/src/main/java/org/jenkinsci/plugins/gwt/Renderer.java index 009948b..03266d1 100644 --- a/src/main/java/org/jenkinsci/plugins/gwt/Renderer.java +++ b/src/main/java/org/jenkinsci/plugins/gwt/Renderer.java @@ -27,7 +27,11 @@ public static boolean isMatching(final String renderedRegexpFilterText, final St final boolean isMatching = compile(nullToEmpty(regexpFilterExpression)) // .matcher(nullToEmpty(renderedRegexpFilterText)) // .find(); - if (!isMatching) { + if (isMatching) { + LOGGER.log( + FINE, + "Triggering \"" + regexpFilterExpression + "\" matching \"" + renderedRegexpFilterText + "\"."); + } else { LOGGER.log( FINE, "Not triggering \"" @@ -35,14 +39,6 @@ public static boolean isMatching(final String renderedRegexpFilterText, final St + "\" not matching \"" + renderedRegexpFilterText + "\"."); - }else{ - LOGGER.log( - FINE, - "Triggering \"" - + regexpFilterExpression - + "\" matching \"" - + renderedRegexpFilterText - + "\"."); } return isMatching; }