From ef70e5393c392e8c00231a67defa0e7825b91ed9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1t=C3=A9=20Tokodi?= Date: Thu, 23 May 2024 12:22:01 +0200 Subject: [PATCH] Fix CI for macos MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Due to compiler bugs present in the latest version of clang on macos: Roll back macos version used by github actions from `macos-latest` (`macos-14`) to `macos-13`: Some modulo operations were failing, such as `-1 % -1` when compiler optimizations were enabled Disable `-Wliteral-range` for test-math.c on macos, because it was falsely raised for `isnan`, `isinf`, and `isfinite ` macros. JerryScript-DCO-1.0-Signed-off-by: Máté Tokodi mate.tokodi@szteszoftver.hu --- .github/workflows/gh-actions.yml | 4 ++-- tests/unit-math/CMakeLists.txt | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/gh-actions.yml b/.github/workflows/gh-actions.yml index f2db5d11c8..85d5659f04 100644 --- a/.github/workflows/gh-actions.yml +++ b/.github/workflows/gh-actions.yml @@ -57,7 +57,7 @@ jobs: - run: $RUNNER -q --jerry-tests --buildoptions=--compile-flag=-m32,--cpointer-32bit=on --build-debug OSX_x86-64_Build_Correctness_Unit_Tests: - runs-on: macos-latest + runs-on: macos-13 steps: - uses: actions/checkout@v2 - uses: actions/setup-python@v4 @@ -67,7 +67,7 @@ jobs: - run: $RUNNER -q --unittests OSX_x86-64_Build_Correctness_Unit_Tests_Debug: - runs-on: macos-latest + runs-on: macos-13 steps: - uses: actions/checkout@v2 - uses: actions/setup-python@v4 diff --git a/tests/unit-math/CMakeLists.txt b/tests/unit-math/CMakeLists.txt index d456731d42..10ca95256a 100644 --- a/tests/unit-math/CMakeLists.txt +++ b/tests/unit-math/CMakeLists.txt @@ -30,6 +30,9 @@ foreach(SOURCE_UNIT_TEST_MAIN ${SOURCE_UNIT_TEST_MAIN_MODULES}) add_executable(${TARGET_NAME} ${SOURCE_UNIT_TEST_MAIN}) set_property(TARGET ${TARGET_NAME} PROPERTY LINK_FLAGS "${LINKER_FLAGS_COMMON}") set_property(TARGET ${TARGET_NAME} PROPERTY RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/tests") + if("${PLATFORM}" STREQUAL "DARWIN") + set_property(TARGET ${TARGET_NAME} PROPERTY COMPILE_OPTIONS "-Wno-literal-range") + endif() target_link_libraries(${TARGET_NAME} jerry-math)