itercost increment

[SamGG]

Hi,
Thanks for your invaluable package.
I am reviewing the code in order to better understand your code organization vs the multicore implementation.
At L220 shouldn't be costi++?

Rtsne/src/tsne.cpp

Lines 219 to 220 in 14b195f

	itercost[costi] = C;
	itercost++;

Is the error (stored in itercost IIUC) monitored/used somewhere in the code?
Best.

[jkrijthe]

Thanks for looking into this. I agree these lines are not very clear, although I guess it still does what it is supposed to do by incrementing the pointer instead of the index. But indeed incrementing costi would be clearer, so I should look into changing this.

The only way itercost is used is to be returned to the user (to get a sense of the loss over the iterations).

What is the multicore implementation you are considering?

[SamGG]

Thanks for your answers.
I am looking at https://github.com/DmitryUlyanov/Multicore-TSNE.
In fact, I want to implement the opt-sne changes in Rtsne.
https://github.com/omiq-ai/Multicore-opt-SNE

[SamGG]

Initial opt-sne integration for proposal in my repo.