-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make chrome notifications show bigger icon and the sending device in the subtext #20
Comments
I think this is a matter or larger images from Android right? From what I see the images are not big enough. Same for the contextual commands. If not let me know what I can do |
I was thinking we can resize the icons a bit in javascript before using them in the notification. But I'll need to check out how to do that :) |
Is this to save on bandwidth? Sorry I just don't know how the notifications work. I'll try and look into it tonight |
Yeah, it is. Got to keep those icons as small as possible. Thanks in advance! |
@joaomgcd I never got a chance to look into this but I'm going to try over the weekend. What's currently using GCM? |
The icons are currently sent using GCM directly :) Their content comes through encoded as Base 64 in the GCM payload itself, so most of them don't even go through my server at all. But since 1 GCM message can only contain 4kB, I shouldn't make them better quality anyway because I don't want to need to send multiple GCM messages per notification. Notifications for windows 10 devices still go through my server though, so there's that. Hope this clears things up! Thanks again |
Yeah resizing doesn't look good even with the simplest of icons never mind more detailed things like album or podcast thumbnails. It would not be an improvement but a step backwards I think. You can just test this by resizing the icons with css in the extension view. The only way I can see this working is to host the files on a server or Drive(?) and use a URL in the payload instead of the base64. I've yet to see larger icons show up on the feature request lists so I'm not sure how many people are actually bothered or care about this to make the work/cost worth it. Though do you have a plan for MMS? Perhaps you can piggy back off that. One other thing was direct device to device. Some push services I've seen in the past had the ability if I remember correctly but I did not see this in any of the GCM docs I looked at. |
Kinda like this: http://imgur.com/bViem9B
The text was updated successfully, but these errors were encountered: