Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hiding "You are disconnected from the internet" message in the settings. #3768

Open
tegridyfarmer opened this issue Dec 18, 2024 · 5 comments

Comments

@tegridyfarmer
Copy link

tegridyfarmer commented Dec 18, 2024

Problem Statement

When I am not connected to the internet everytime I open a new superProductivity instance it shows me a message.

❔ Possible Solution

Make a toggle that allows hiding this banner.

⤴️ Describe alternatives you've considered

Make it auto-dismiss after a few seconds.
Add a option for "Dont show again" besides the current "Dismiss".

➕ Additional context

I am using the Flatpak version.

Copy link

Thank you very much for opening up this issue! I am currently a bit overwhelmed by the many requests that arrive each week, so please forgive me, if I fail to respond personally. I am still very likely to at least skim read your request and I'll probably try to fix all (real) bugs if possible and I will likely review every single PR being made (please, give me a heads up if you intent to do so) and I will try to work on popular requests (please upvote via thumbs up on the original issue) whenever possible, but trying to respond to every single issue over the last years has been kind of draining and I need to adjust my approach for this project to remain fun for me and to make any progress with actually coding new stuff. Thanks for your understanding!

@johannesjo
Copy link
Owner

johannesjo commented Dec 18, 2024

Before adding this, we need to evaluate, what might be affected by this (issue integrations and sync). We generally should aim to handle this more gracefully (maybe ditching the banner completely and only providing the info when a request is attempted).

@tegridyfarmer
Copy link
Author

Maybe something like a network icon that indicates a network connection would be good?
Then you can click on it for extra information, but I would not know a good placing in the UI for it.

@johannesjo
Copy link
Owner

johannesjo commented Dec 18, 2024

Maybe something like a network icon that indicates a network connection would be good? Then you can click on it for extra information, but I would not know a good placing in the UI for it.

That is a good idea! Maybe it could replace the sync icon when shown.

@tegridyfarmer
Copy link
Author

tegridyfarmer commented Dec 18, 2024

Or it would only show a network icon like below, if there is no network connection.
image
Which is then clickable for more information, so it does not show anything if there is a network connection.
But I am curious what you think would be a good implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants