Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node_modules size increased by more than 200% #390

Open
jojomatik opened this issue Apr 9, 2022 · 1 comment
Open

node_modules size increased by more than 200% #390

jojomatik opened this issue Apr 9, 2022 · 1 comment
Assignees
Labels
type:fix A bug report or fix

Comments

@jojomatik
Copy link
Owner

jojomatik commented Apr 9, 2022

Describe the bug
The size of node_modules increased by more than 200%, the size of the docker image increased by around 50% between v0.10.5 and v0.11.0-beta.1.

Environment:

Additional context
I suppose minecraft-protocol has a lot of dependencies. I will create an issue in that repository as soon as I've confirmed that.

Before:
image

image

After:
image

image

@jojomatik jojomatik added the type:fix A bug report or fix label Apr 9, 2022
@jojomatik jojomatik self-assigned this Apr 9, 2022
@jojomatik jojomatik changed the title Docker image size increased by around 50% node_modules size increased by more than 200% Apr 9, 2022
@jojomatik
Copy link
Owner Author

As mentioned in PrismarineJS/node-minecraft-protocol#978 (comment) download times of new docker images should not be affected too much as docker images are compressed and the relevant package minecraft-data is highly compressable.

They seem to get uncompressed as soon as they are downloaded, but that shouldn't be too much of an issue then the more I think about i. If I remove all unused/ old images and never have to run a lot of different versions of my software at the same time, those 70MB should not cause any issues.

PrismarineJS/node-minecraft-data#185 aims to publish the compressed files and to decompress them at runtime. I'll keep this issue open until that issue is closed either by a fix or because it is unreasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:fix A bug report or fix
Projects
None yet
Development

No branches or pull requests

1 participant