Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider issuing warnings for multiple Clojure symbol names that map to same strings after munge #281

Open
jafingerhut opened this issue Sep 5, 2018 · 0 comments

Comments

@jafingerhut
Copy link
Collaborator

Excerpts from a conversation on Clojurians Slack channel #clojure-dev on 2018-Sep-05:

"I had an issue where I had two functions in a file, replace-_ and replace_-. This worked in dev, but when I aot the project, any invocation of either is replaced by the last one in the file. I suppose this is because munge gives the same result for both those names."

"The clojure names of the fns are foo.common.core/replace-_ (and replace_-). The class in the jar is /foo/common/core$replace__.class"

Eastwood already issues a warning when def'ing the same name twice. A new check could be implemented as a variation of that one. If so, it would probably be best to name it differently than the current one, so they could be turned on/off independently of each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant