Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit code is non-zero when no namespaces are linted and caching is enabled #454

Open
kjothen opened this issue Jul 9, 2024 · 0 comments · Fixed by #453
Open

Exit code is non-zero when no namespaces are linted and caching is enabled #454

kjothen opened this issue Jul 9, 2024 · 0 comments · Fixed by #453

Comments

@kjothen
Copy link
Contributor

kjothen commented Jul 9, 2024

Linting a large monorepo is time-consuming in CI builds. This can be mitigated by caching the .eastwood file between runs on the same branch. However, eastwood returns a non-zero exit code when no namespaces were linted, which is problematic. Rather than ignore the error code and continue the build, it would be better to return a zero error code in this circumstance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant