Not all files and folders removed by Joomla\CMS\Installer\Adapter\FileAdapter

[pjdevries]

It seems that Joomla\CMS\Installer\Adapter\FileAdapter does not delete all files and folders that were installed. This piece of code, starting at line 292, is the culprit:

	// Delete any folders that don't have any content in them.
	foreach ($folderList as $folder)
	{
		$files = Folder::files($folder);

		if ($files !== false && !\count($files))
		{
			Folder::delete($folder);
		}
	}

Why aren't all folders deleted recursively? Is this simply a mistake or intentional behavior? And if intentional, what should an installer manifest look like, that installs several files and sub folders, containing files as well, in for instance layouts\com_foo?

[richard67]

Folder::delete does delete all content of the folder recursively, see the method here: https://github.com/joomla/joomla-cms/blob/4.2-dev/libraries/src/Filesystem/Folder.php#L272 .

You can try that yourself by creating a temporary folder e.g. inside your Joomla's tmp folder, filling that folder with some subfolders and files, adding a use Joomla\CMS\Filesystem\Folder; and a Folder::delete('/full/path/to/the/previously/mentioned/folder'); to your frontend template's index.php, visit your site and then check if the folder is still there.

[richard67]

If you do it like I've written in my previous comment, you can safely install your files into existing folders which are also used by the core or by other 3rd party extensions, and the files would be properly removed on uninstall.

[pjdevries]

I will make the necessary changes in my manifest :)

[richard67]

Are there any docs for the file type manifest?

Not that I knew of, except of the one I had linked before which only briefly explains what that type is good for: https://docs.joomla.org/Extension_types_(general_definitions)#File

In the documentation for manifest files this type is not described, also not the "target" attribute of the "files" element: https://docs.joomla.org/Manifest_files

[richard67]

I will make the necessary changes in my manifest :)

Let us know if it works because I haven't tested my suggestion yet.

[pjdevries]

I'll do that later today and let you know.

[pjdevries]

Apologies for not keeping my "later today" promise. I just tested a few variations, starting with the one you suggested last:

<fileset>
    <files folder="layouts/files_manifest_test" target="layouts/files_manifest_test">
        <file>folder1/bar.php</file>
        <file>folder2/baz.php</file>
        <file>foo.php</file>
    </files>
</fileset>

This variation installs all files and folders properly. However, on uninstallation, it deletes all files and folders, except the top folder files_manifest_test. It can be remedied by explicitly including that folder in the files & folders list and excluding it from the <files> folder and target attributes:

<fileset>
    <files folder="layouts" target="layouts">
        <folder>files_manifest_test</folder>
        <file>files_manifest_test/folder1/bar.php</file>
        <file>files_manifest_test/folder2/baz.php</file>
        <file>files_manifest_test/foo.php</file>
    </files>
</fileset>

With this arrangement all files and folders are properly installed and deleted on uninstallation.