New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect dimension reduction #2

Open

gpassero opened this issue Aug 15, 2016 · 0 comments

gpassero commented Aug 15, 2016

I think lsa.py file has an error, currently it's

            #Dimension reduction, build SIGMA'
            for index in xrange(rows - dimensions, rows):
                sigma[index] = 0

shouldn't it be:

        for index in xrange(dimensions, rows):
            print('setting index to 0 - ', index)

The way it is now, a lower dimension will cause better/more precise results.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment