Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nerd fonts dont render when i use sesh to create a new tmux session #103

Open
2 tasks done
SuyashPatil-29 opened this issue May 11, 2024 · 21 comments
Open
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@SuyashPatil-29
Copy link

What happened?

When I open a new session using sesh my nerdfonts dont render nor on my terminal nor in my neovim

Expected -

image

Whats happening -

image

On neovim -
Expected -

image

Whats happening -

image

Version

sesh version dev

Relevant log output

No response

Reviewed

  • Reviewed existing issues and made sure this bug has not already been submitted.
  • I have read the documentation and understand how sesh works before submitting this bug
@SuyashPatil-29 SuyashPatil-29 added the bug Something isn't working label May 11, 2024
@SuyashPatil-29
Copy link
Author

I am on ubuntu 22.04 and have the nerd fonts installed and working.

@joshmedeski
Copy link
Owner

Interesting, how are you calling sesh? Just directly in the terminal "sesh connect 'ai-roadmap-generator'"?

Also, if you run this outside of tmux, do you see icons?

sesh list -i

@Hugo-Persson
Copy link

Hugo-Persson commented May 12, 2024

I have the same issue on mac

If I run:

sesh list -i | fzf-tmux -p 55%,60% \
		--no-sort --border-label ' sesh ' --prompt '⚡  ' \
		--header '  ^a all ^t tmux ^g configs ^x zoxide ^d tmux kill ^f find' \
		--bind 'tab:down,btab:up' \
		--bind 'ctrl-a:change-prompt(⚡  )+reload(sesh list)' \
		--bind 'ctrl-t:change-prompt(🪟  )+reload(sesh list -t)' \
		--bind 'ctrl-g:change-prompt(⚙️  )+reload(sesh list -c)' \
		--bind 'ctrl-x:change-prompt(📁  )+reload(sesh list -z)' \
		--bind 'ctrl-f:change-prompt(🔎  )+reload(fd -H -d 2 -t d -E .Trash . ~)' \
		--bind 'ctrl-d:execute(tmux kill-session -t {})+change-prompt(⚡  )+reload(sesh list -i)'

I get:
image

If I run:

sesh list -i

I get the expected result:
image

My fzf version is:

> fzf --version
0.49.0 (brew)

@joshmedeski
Copy link
Owner

Thanks for the feedback, so it appears to break the Nerd Font rendering  only when sesh starts the tmux session.

I will do some investigation, sometimes it's related to the default terminal setting, try checking this value or setting it in your tmux.conf:

set -g default-terminal "screen-256color"

Other times, it can be unicode support problem, which came be set in your tmux.conf as well:

set -g utf8
setw -g utf8 on

Can you experiment with these settings and see if it helps? I can setup a VM and try and recreate the issue, or ask my community if anyone else uses sesh with Ubuntu, but let's see if updating the configuration can fix it first, thanks!

@Hugo-Persson
Copy link

@SuyashPatil-29 could you try restarting your computer without changing anything in your tmux.conf? I tried it now and fixed everything for me, maybe something weird when changing from the old plugin to the new plugin?

@SuyashPatil-29
Copy link
Author

Interesting, how are you calling sesh? Just directly in the terminal "sesh connect 'ai-roadmap-generator'"?

Also, if you run this outside of tmux, do you see icons?

sesh list -i

When I run

sesh list -i

I do see my icons. Its only when I use sesh connect i get the problem. BTW I use kitty as my terminal emulator.

And yes "sesh connect 'ai-roadmap-generator'" is what I did to directly jump into a session.

@SuyashPatil-29
Copy link
Author

@SuyashPatil-29 could you try restarting your computer without changing anything in your tmux.conf? I tried it now and fixed everything for me, maybe something weird when changing from the old plugin to the new plugin?

I did try this. I have had this issue about a month ago too. I decided to not use sesh then but now that I tried again hoping it would be fixed, its the same again.

@SuyashPatil-29
Copy link
Author

Thanks for the feedback, so it appears to break the Nerd Font rendering  only when sesh starts the tmux session.

I will do some investigation, sometimes it's related to the default terminal setting, try checking this value or setting it in your tmux.conf:

set -g default-terminal "screen-256color"

Other times, it can be unicode support problem, which came be set in your tmux.conf as well:

set -g utf8
setw -g utf8 on

Can you experiment with these settings and see if it helps? I can setup a VM and try and recreate the issue, or ask my community if anyone else uses sesh with Ubuntu, but let's see if updating the configuration can fix it first, thanks!

I did this and it did not help. I dont think its a problem with my kitty conf as it renders everything else properly

@joshmedeski
Copy link
Owner

Have you tried a different terminal emulator? If it's just kitty that's not working that will help me in debugging what could be the root cause.

@karamanliev
Copy link

karamanliev commented May 14, 2024

I have the same issue on mac

If I run:

sesh list -i | fzf-tmux -p 55%,60% \
		--no-sort --border-label ' sesh ' --prompt '⚡  ' \
		--header '  ^a all ^t tmux ^g configs ^x zoxide ^d tmux kill ^f find' \
		--bind 'tab:down,btab:up' \
		--bind 'ctrl-a:change-prompt(⚡  )+reload(sesh list)' \
		--bind 'ctrl-t:change-prompt(🪟  )+reload(sesh list -t)' \
		--bind 'ctrl-g:change-prompt(⚙️  )+reload(sesh list -c)' \
		--bind 'ctrl-x:change-prompt(📁  )+reload(sesh list -z)' \
		--bind 'ctrl-f:change-prompt(🔎  )+reload(fd -H -d 2 -t d -E .Trash . ~)' \
		--bind 'ctrl-d:execute(tmux kill-session -t {})+change-prompt(⚡  )+reload(sesh list -i)'

I get: image

If I run:

sesh list -i

I get the expected result: image

My fzf version is:

> fzf --version
0.49.0 (brew)

I can report that I have absolutely the same issue on mac and linux with wezterm terminal. Everything is updated to the latest available version.

I've managed to make it working for me with the following tmux bind:

bind-key "r" run-shell "sesh connect \"$(
    sesh list -i | fzf-tmux -p 55%,60% --layout=reverse --ansi \
        --no-sort --border-label ' sesh ' --prompt '' \
        --header '  ^a all ^t tmux ^g configs ^x zoxide ^d tmux kill ^f find' \
        --bind 'tab:down,btab:up' \
        --bind 'ctrl-a:change-prompt(⚡  )+reload(sesh list -i)' \
        --bind 'ctrl-t:change-prompt(🪟  )+reload(sesh list -t -i)' \
        --bind 'ctrl-g:change-prompt(⚙️  )+reload(sesh list -c -i)' \
        --bind 'ctrl-x:change-prompt(📁  )+reload(sesh list -z -i)' \
        --bind 'ctrl-f:change-prompt(🔎  )+reload(fd -H -d 2 -t d -E .Trash . ~)' \
        --bind 'ctrl-d:execute(tmux kill-session -t $(echo {} | cut -c3-))+change-prompt(⚡  )+reload(sesh list -i)'
)\""

Thanks for the great app, I love it! 👊

@SuyashPatil-29
Copy link
Author

I have the same issue on mac
If I run:

sesh list -i | fzf-tmux -p 55%,60% \
		--no-sort --border-label ' sesh ' --prompt '⚡  ' \
		--header '  ^a all ^t tmux ^g configs ^x zoxide ^d tmux kill ^f find' \
		--bind 'tab:down,btab:up' \
		--bind 'ctrl-a:change-prompt(⚡  )+reload(sesh list)' \
		--bind 'ctrl-t:change-prompt(🪟  )+reload(sesh list -t)' \
		--bind 'ctrl-g:change-prompt(⚙️  )+reload(sesh list -c)' \
		--bind 'ctrl-x:change-prompt(📁  )+reload(sesh list -z)' \
		--bind 'ctrl-f:change-prompt(🔎  )+reload(fd -H -d 2 -t d -E .Trash . ~)' \
		--bind 'ctrl-d:execute(tmux kill-session -t {})+change-prompt(⚡  )+reload(sesh list -i)'

I get: image
If I run:

sesh list -i

I get the expected result: image
My fzf version is:

> fzf --version
0.49.0 (brew)

I can report that I have absolutely the same issue on mac and linux with wezterm terminal. Everything is updated to the latest available version.

I've managed to make it working for me with the following tmux bind:

bind-key "r" run-shell "sesh connect \"$(
    sesh list -i | fzf-tmux -p 55%,60% --layout=reverse --ansi \
        --no-sort --border-label ' sesh ' --prompt '' \
        --header '  ^a all ^t tmux ^g configs ^x zoxide ^d tmux kill ^f find' \
        --bind 'tab:down,btab:up' \
        --bind 'ctrl-a:change-prompt(⚡  )+reload(sesh list -i)' \
        --bind 'ctrl-t:change-prompt(🪟  )+reload(sesh list -t -i)' \
        --bind 'ctrl-g:change-prompt(⚙️  )+reload(sesh list -c -i)' \
        --bind 'ctrl-x:change-prompt(📁  )+reload(sesh list -z -i)' \
        --bind 'ctrl-f:change-prompt(🔎  )+reload(fd -H -d 2 -t d -E .Trash . ~)' \
        --bind 'ctrl-d:execute(tmux kill-session -t $(echo {} | cut -c3-))+change-prompt(⚡  )+reload(sesh list -i)'
)\""

Thanks for the great app, I love it! 👊

Thanks a ton man this works perfectly fine for me.

@joshmedeski
Copy link
Owner

Awesome, thanks everyone for the feedback and help!

@SuyashPatil-29
Copy link
Author

sesh connect ai-roadmap-generator still does not render the nerd fonts tho @joshmedeski

@joshmedeski
Copy link
Owner

Hmm, did you confirm the Nerd Fonts render in a different terminal emulator?

@joshmedeski joshmedeski reopened this May 14, 2024
@marcellmartini
Copy link

What is the NerdFonts and Tmux version?

@SuyashPatil-29
Copy link
Author

Hmm, did you confirm the Nerd Fonts render in a different terminal emulator?

I did try using the native ubuntu terminal and its the same thing

@SuyashPatil-29
Copy link
Author

What is the NerdFonts and Tmux version?

SF Mono nerd font but i also tried it with many other nerd fonts and its the same thing

and the tmux version is 3.2a

@marcellmartini
Copy link

What is the NerdFonts and Tmux version?

SF Mono nerd font but i also tried it with many other nerd fonts and its the same thing

and the tmux version is 3.2a

I ask the version of Nerdfonts because some time ago the download link on the Nerdfonts page was not up to date. Downloading from the website the version font was 2.4 and download the font from GitHub repo the version was 3.2.

I checked today and the versions are equal on the website and in the GitHub repo. Would you happen to know what version you installed the Nerdfont?

I have some issues with the missing Fonts because of this version difference.

@joshmedeski
Copy link
Owner

Thanks for the feedback, @SuyashPatil-29.

I'm currently rewriting the code to make testing and debugging easier. Please bear with me as this process will take a few weeks. I'll look into this issue as soon as possible, but it's not my top priority right now since I have limited time outside my day job.

@SuyashPatil-29
Copy link
Author

What is the NerdFonts and Tmux version?

SF Mono nerd font but i also tried it with many other nerd fonts and its the same thing
and the tmux version is 3.2a

I ask the version of Nerdfonts because some time ago the download link on the Nerdfonts page was not up to date. Downloading from the website the version font was 2.4 and download the font from GitHub repo the version was 3.2.

I checked today and the versions are equal on the website and in the GitHub repo. Would you happen to know what version you installed the Nerdfont?

I have some issues with the missing Fonts because of this version difference.

I did not download from the web page, i cloned the git repo and patched the fonts myself and they render well when i use tmux or neovim normally so thats not a problem ig.

@SuyashPatil-29
Copy link
Author

Thanks for the feedback, @SuyashPatil-29.

I'm currently rewriting the code to make testing and debugging easier. Please bear with me as this process will take a few weeks. I'll look into this issue as soon as possible, but it's not my top priority right now since I have limited time outside my day job.

Thanks a lot josh i can still manage without the sesh connect I am here so that this issue would be resolved causing others no trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

5 participants