-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove (or make optional) the zoxide
and tmux
dependencies in the goreleaser Brew config
#118
Comments
I'm currently using GoReleaser to generate the homebrew tap which doesn't support the recommended or optional feature right now, but I can reach out and see if that's something that could be added. For now, I think |
Nice! I searched the docs and couldn't find this myself. So I'm leaning toward making it a |
Tough to say for me tbh, my intuition may be skewed; macOS is my daily driver, but I don't usually use So for me, I like |
Since your the outlier here I'm going to leave everything as-is. I think it makes the most sense for most people. #68 is open right now and I'll be adding Debian support, so your edge-case here will go away when that package becomes available. Thanks for discussing this and working through it with me. |
What would you like sesh to do?
By having those dependencies declared as part of the homebrew package, users who have
tmux
and/orzoxide
installed by other means will end up having the executables installed bybrew
in order to usesesh
, which may not be desired.linuxbrew
users might havezoxide
and/ortmux
installed as a native OS packge, but still want to usebrew
to installsesh
One workaround is to pass
--ignore-dependencies
to the brew install command, but then you get a loud warning.They could also be marked as either
recommended
(which would require the user to pass--without-<dep>
) oroptional
(which would require--with-<dep>
).The text was updated successfully, but these errors were encountered: