Unable to import flights from flightmemory.com #1398
Comments
jb1991dd
changed the title
reedy
added
import
|
Do you know offhand when it last worked? I don't have access to the server to check the tmpfile.... |
|
And can you provide a copy of your HTML? |
|
Around 20th May 2023 it was the last time I imported flights. |
|
I signed up for flightmemory and just put one simple flight on, that worked... Your small file worked fine
Your larger one is rejected because BER doesn't exist in the default dataset (but will exist on openflights.org)... Will add it manually for my dev install (and file a followup issue), and see where we are... |
|
The short file has some logspam (on initial parse, even if it worked)... The longer file has much more... Probably explains at least some of the issues on openflights.org... |
|
Interesting that it worked for you. I looked in my old backup and tried to upload an old file which I saved 2020, which always worked fine in the past. |
|
I haven't actually imported the large one yet, as I've gone down rabbit holes of fixing other issues. If it was a browser based problem, it would be in the HTML that was saved. The parsing is done "server side" in PHP... It's also possible whatever the issue was may be fixed in the repo, but not deployed yet. Or it's related to the config being used on the server, and all those warnings are upsetting things. They are both broken on openflights.org for me, but locally on my dev environment I definitely can at least get past the first pass... And fully import the first, the second I can't because of BER being missing in my dataset (various tasks spun off). I'm gonna try and clean up some of those warnings and then we might need to get server logs, and/or wait for #1391 and see if it's fixed on openflights.org post deployment. |
|
Can you eyeball this image for me?
Does it look like it has everything it should have? |
reedy
added a commit
that referenced
this issue
Jul 26, 2023
* No registration and/or no name/title for the plane * No aiport name, just the City/Town and Country * Fall back to returning '' in nth_text() if we can't find what we're looking for More towards #1398
|
I'm suspecting there may be some different handling with 36da5e2 than before, and that maybe wasn't deployed when you last tried... It was as of late June. That second commit just pushed fixes up the other logspam that I pasted above. It's basically due to it expecting things like plane registrations, plane "names", airport "names"... All of which can be missing as evident by your dataset. I've added some extra fallback handling so that if this happens on other fields, it will just return an empty string quietly... ish... |
|
Your image with all flights looks perfect. |
|
Great. I'm gonna call this fixed then; it should be deployed in the near future. Feel free to reopen or file a new issue if there are still issues after updated code is deployed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Unfortunatelly it is not importing my flights from flightmemory.com.
For years I never had any issues. But this time it says:
Upload successful. Parsing...
Results
Tmpfile phpkgOCAs
Any ideas anyone?
The text was updated successfully, but these errors were encountered: