Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for django-reversion #203

Open
jrief opened this issue Nov 8, 2016 · 2 comments
Open

Remove support for django-reversion #203

jrief opened this issue Nov 8, 2016 · 2 comments

Comments

@jrief
Copy link
Owner

jrief commented Nov 8, 2016

django-reversion uses a JSON field to store a serialized version of the model fields. This in practice means that we would store our JSON payload inside another JSON field, which is kind of silly.

I therefore would suggest to rewrite the reversion functionality and add it to Cascade itself.

Side Note: The contributors of django-cms also want to remove support for reversion in their code base.

@rfleschenberg
Copy link
Collaborator

If django-cms removes reversion support, I see no reason why we should keep it. However, IMHO we should keep supporting reversion until we drop support for all django-cms releases that offer reversion support, unless keeping the reversion support is a big maintenance burden for us.

I am not so sure about adding versioning / undo support to cascade itself.

  • Can this live in a separate app?
  • What is django-cms's plan for the future? Switch to another solution, or drop reversion / undo support altogether?

@rfleschenberg
Copy link
Collaborator

czpython wrote on the django-cms mailing list:

The undo/redo functionality will come in our next 3.4.x release as its being developed separate from the core.

I suggest that we

  • drop reversion support in all cascade releases that only support django-cms >= 3.4,
  • wait until the django-cms undo/redo package is released before we start working on a possible undo/redo implementation of our own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants