Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin menu #319

Open
haricot opened this issue Feb 15, 2019 · 3 comments
Open

Plugin menu #319

haricot opened this issue Feb 15, 2019 · 3 comments

Comments

@haricot
Copy link
Contributor

haricot commented Feb 15, 2019

I would like to propose a plugin menu, what do you think this, did you see a disadvantage?

@jrief
Copy link
Owner

jrief commented Feb 15, 2019

Could you please elaborate on this. Where would you put that menu and what do you want to show inside?

@haricot
Copy link
Contributor Author

haricot commented Feb 16, 2019

it would be a Navbar plugin for the main menu placed in a static placeholder that could have child plugins, with the possibility to use get_render_template () for example to add the possibility of having a drawer on one side .
I had done a few things of the same kind and I would like to make it clean, but I wonder if there is a problem with that, I do not see it at the moment, apart from that it sometimes requires refreshing the front end when making changes, and maybe the menu cache sometimes has to be invalidated
there is a lot of possibility with the menus, cascade already has almost everything you need for that.
This will not prevent me from the complexity that a menu may have sometimes but this could come from a clipboard menu gallery.
Do you see an interest in it?

@jrief
Copy link
Owner

jrief commented Feb 16, 2019

Got it!
I actually always believed, that most developers would override the menu templates, as provided by djangocms-bootstrap anyway. This is because the main menu very often is one of the most unique parts of a site.

One valid point would be to create secondary menus somewhere on arbitrary pages. Secondary menus often are much more standardized, less unique and have to be either placed somewhere or not.

Feel free to proceed with such a plugin. If it doesn't fit into Cascade's bootstrap-4 plugin mindset, it may be published as third-party app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants