Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transaction.security and position.security should be Security() object instead of str #158

Open
hezhao opened this issue Apr 16, 2020 · 1 comment

Comments

@hezhao
Copy link

hezhao commented Apr 16, 2020

transaction.security and position.security currently are only assigned as str of CUSIP number, instead it should be a Security() object, so that more useful ticker symbol can also be obtained. I see that ofx.security_list already parses a list of Security() objects, it should not be difficult to create a lookup map with CUSIP as key and Security() object as value.

transaction.security = tag.contents[0].strip()

position.security = tag.contents[0].strip()

@bzbarsky
Copy link

bzbarsky commented Aug 4, 2020

In particular, the docs at https://github.com/jseutter/ofxparse/blob/master/README.rst already claim that this is a Security object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants