From 12e37114c7ed2378ae0fb6254d6ea08062ba0416 Mon Sep 17 00:00:00 2001 From: jshemas Date: Mon, 16 Sep 2024 20:13:28 -0400 Subject: [PATCH 1/6] remove new lines from jsonLD --- lib/extract.ts | 1 + tests/unit/static.spec.ts | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/lib/extract.ts b/lib/extract.ts index 6887262..0c6bf52 100644 --- a/lib/extract.ts +++ b/lib/extract.ts @@ -97,6 +97,7 @@ export default function extractMetaTags(body: string, options: OpenGraphScraperO if (!ogObject.jsonLD) ogObject.jsonLD = []; let scriptText = $(script).text(); if (scriptText) { + scriptText = scriptText.replace(/(\r\n|\n|\r)/gm, ''); // remove newlines scriptText = unescapeScriptText(scriptText); ogObject.jsonLD.push(JSON.parse(scriptText)); } diff --git a/tests/unit/static.spec.ts b/tests/unit/static.spec.ts index b4a0e84..d7c3ccd 100644 --- a/tests/unit/static.spec.ts +++ b/tests/unit/static.spec.ts @@ -235,6 +235,28 @@ describe('static check meta tags', function () { }); }); + it('jsonLD - with new lines', function () { + const metaHTML = ` + + + `; + + mockAgent.get('http://www.test.com') + .intercept({ path: '/' }) + .reply(200, metaHTML); + + return ogs({ url: 'www.test.com' }) + .then(function (data) { + expect(data.result.success).to.be.eql(true); + expect(data.result.requestUrl).to.be.eql('http://www.test.com'); + expect(data.result.jsonLD).to.be.eql([{ foo: ' bar ' }]); + expect(data.html).to.be.eql(metaHTML); + expect(data.response).to.be.a('response'); + }); + }); + it('encoding - utf-8', function () { /* eslint-disable max-len */ const metaHTML = ` From 446f6c3cc570fce24e6f80010d45fffc68741400 Mon Sep 17 00:00:00 2001 From: jshemas Date: Mon, 16 Sep 2024 20:53:09 -0400 Subject: [PATCH 2/6] if string is not isLatin1 then encode it --- lib/request.ts | 10 ++++-- tests/integration/encoding.spec.ts | 51 ++++++++++++++++++++++++++++++ 2 files changed, 59 insertions(+), 2 deletions(-) diff --git a/lib/request.ts b/lib/request.ts index d719e5b..a7a0d46 100644 --- a/lib/request.ts +++ b/lib/request.ts @@ -48,12 +48,18 @@ export default async function requestAndResultsFormatter(options: OpenGraphScrap let body; let response; try { + // eslint-disable-next-line no-control-regex + const isLatin1 = /^[\u0000-\u00ff]{0,}$/; + + let url = options.url ?? ''; + if (!isLatin1.test(url)) url = encodeURI(url); + response = await fetch( - options.url ?? '', + url ?? '', { signal: AbortSignal.timeout((options.timeout ?? 10) * 1000), ...options.fetchOptions, - headers: { Origin: options.url ?? '', Accept: 'text/html', ...options.fetchOptions?.headers }, + headers: { Origin: url ?? '', Accept: 'text/html', ...options.fetchOptions?.headers }, }, ); diff --git a/tests/integration/encoding.spec.ts b/tests/integration/encoding.spec.ts index 20be789..f425bac 100644 --- a/tests/integration/encoding.spec.ts +++ b/tests/integration/encoding.spec.ts @@ -631,4 +631,55 @@ describe('encoding', function () { expect(response).to.be.an('Response'); }); }); + + it('velog - ByteString issues with URL', function () { + this.timeout(30000); + return ogs({ url: 'https://velog.io/@skynet/직사각형의-넓이는-왜-가로세로일까', timeout: 30 }) + .then(function (data) { + const { error, result, response } = data; + console.log('error:', error); + console.log('result:', result); + expect(error).to.be.eql(false); + expect(result.fbAppId).to.be.eql('203040656938507'); + expect(result.ogUrl).to.be.eql('https://velog.io/@skynet/직사각형의-넓이는-왜-가로세로일까'); + expect(result.ogType).to.be.eql('article'); + expect(result.ogTitle).to.be.eql('직사각형의 넓이는 왜 가로×세로일까?'); + expect(result.ogDescription).to.be.eql('제목의 질문에 말문이 막혔다면 한 번 읽어보세요.'); + expect(result.twitterCard).to.be.eql('summary_large_image'); + expect(result.twitterTitle).to.be.eql('직사각형의 넓이는 왜 가로×세로일까?'); + expect(result.twitterDescription).to.be.eql('제목의 질문에 말문이 막혔다면 한 번 읽어보세요.'); + expect(result.ogImage).to.be.eql([ + { + url: 'https://velog.velcdn.com/images/skynet/post/d0f53ddc-9f62-4fc9-90e8-9f9f344e0d49/image.png', + type: 'png', + }, + ]); + expect(result.twitterImage).to.be.eql([ + { + url: 'https://velog.velcdn.com/images/skynet/post/d0f53ddc-9f62-4fc9-90e8-9f9f344e0d49/image.png', + }, + ]); + expect(result.favicon).to.be.eql('https://static.velog.io/favicon.ico'); + expect(result.charset).to.be.eql('UTF-8'); + expect(result.requestUrl).to.be.eql('https://velog.io/@skynet/직사각형의-넓이는-왜-가로세로일까'); + expect(result.success).to.be.eql(true); + expect(result).to.have.all.keys( + 'charset', + 'favicon', + 'fbAppId', + 'ogDescription', + 'ogImage', + 'ogTitle', + 'ogType', + 'ogUrl', + 'requestUrl', + 'success', + 'twitterCard', + 'twitterDescription', + 'twitterImage', + 'twitterTitle', + ); + expect(response).to.be.an('Response'); + }); + }); }); From c1b643738e4422a1d2e0eec784ebe5f2c5eb7295 Mon Sep 17 00:00:00 2001 From: jshemas Date: Mon, 16 Sep 2024 20:55:17 -0400 Subject: [PATCH 3/6] updating change log --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 20d0dff..5e4bde6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # Change Log +## 6.8.2 + +- Remove new lines from jsonLD. +- If url string is not `isLatin1` then encode it, otherwise you will run into `ByteString` errors within `fetch` +- Updating dependencies + ## 6.8.1 - Fixing issue where setting `fetchOptions.headers` would replace the default `headers` From 0cf8bba5c75c1acfb9b9aa61f9d9ca6022af5108 Mon Sep 17 00:00:00 2001 From: jshemas Date: Tue, 17 Sep 2024 18:57:16 -0400 Subject: [PATCH 4/6] updating dependencies --- package-lock.json | 161 +++++++++++++++++++++++----------------------- package.json | 10 +-- 2 files changed, 86 insertions(+), 85 deletions(-) diff --git a/package-lock.json b/package-lock.json index f9660b3..7d6ab34 100644 --- a/package-lock.json +++ b/package-lock.json @@ -15,21 +15,21 @@ "undici": "^6.19.8" }, "devDependencies": { - "@snyk/protect": "^1.1293.0", - "@types/mocha": "^10.0.7", - "@types/node": "^18.19.47", + "@snyk/protect": "^1.1293.1", + "@types/mocha": "^10.0.8", + "@types/node": "^18.19.50", "@typescript-eslint/eslint-plugin": "^7.18.0", "@typescript-eslint/parser": "^7.18.0", "chai": "^4.5.0", "eslint": "^8.57.0", "eslint-config-airbnb-base": "^15.0.0", "eslint-config-airbnb-typescript": "^18.0.0", - "eslint-plugin-import": "^2.29.1", + "eslint-plugin-import": "^2.30.0", "eslint-plugin-mocha": "^10.5.0", "eslint-plugin-promise": "^7.1.0", "mocha": "^10.7.3", "nyc": "^17.0.0", - "sinon": "^18.0.0", + "sinon": "^19.0.2", "ts-mocha": "^10.0.0", "typescript": "^5.5.4" }, @@ -723,6 +723,12 @@ "node": ">= 8" } }, + "node_modules/@rtsao/scc": { + "version": "1.1.0", + "resolved": "https://registry.npmjs.org/@rtsao/scc/-/scc-1.1.0.tgz", + "integrity": "sha512-zt6OdqaDoOnJ1ZYsCYGt9YmWzDXl4vQdKTyJev62gFhRGKdx7mcT54V9KIjg+d2wi9EXsPvAPKe7i7WjfVWB8g==", + "dev": true + }, "node_modules/@sinonjs/commons": { "version": "3.0.1", "resolved": "https://registry.npmjs.org/@sinonjs/commons/-/commons-3.0.1.tgz", @@ -742,53 +748,35 @@ } }, "node_modules/@sinonjs/fake-timers": { - "version": "11.2.2", - "resolved": "https://registry.npmjs.org/@sinonjs/fake-timers/-/fake-timers-11.2.2.tgz", - "integrity": "sha512-G2piCSxQ7oWOxwGSAyFHfPIsyeJGXYtc6mFbnFA+kRXkiEnTl8c/8jul2S329iFBnDI9HGoeWWAZvuvOkZccgw==", + "version": "13.0.2", + "resolved": "https://registry.npmjs.org/@sinonjs/fake-timers/-/fake-timers-13.0.2.tgz", + "integrity": "sha512-4Bb+oqXZTSTZ1q27Izly9lv8B9dlV61CROxPiVtywwzv5SnytJqhvYe6FclHYuXml4cd1VHPo1zd5PmTeJozvA==", "dev": true, "dependencies": { - "@sinonjs/commons": "^3.0.0" + "@sinonjs/commons": "^3.0.1" } }, "node_modules/@sinonjs/samsam": { - "version": "8.0.0", - "resolved": "https://registry.npmjs.org/@sinonjs/samsam/-/samsam-8.0.0.tgz", - "integrity": "sha512-Bp8KUVlLp8ibJZrnvq2foVhP0IVX2CIprMJPK0vqGqgrDa0OHVKeZyBykqskkrdxV6yKBPmGasO8LVjAKR3Gew==", + "version": "8.0.2", + "resolved": "https://registry.npmjs.org/@sinonjs/samsam/-/samsam-8.0.2.tgz", + "integrity": "sha512-v46t/fwnhejRSFTGqbpn9u+LQ9xJDse10gNnPgAcxgdoCDMXj/G2asWAC/8Qs+BAZDicX+MNZouXT1A7c83kVw==", "dev": true, "dependencies": { - "@sinonjs/commons": "^2.0.0", + "@sinonjs/commons": "^3.0.1", "lodash.get": "^4.4.2", - "type-detect": "^4.0.8" - } - }, - "node_modules/@sinonjs/samsam/node_modules/@sinonjs/commons": { - "version": "2.0.0", - "resolved": "https://registry.npmjs.org/@sinonjs/commons/-/commons-2.0.0.tgz", - "integrity": "sha512-uLa0j859mMrg2slwQYdO/AkrOfmH+X6LTVmNTS9CqexuE2IvVORIkSpJLqePAbEnKJ77aMmCwr1NUZ57120Xcg==", - "dev": true, - "dependencies": { - "type-detect": "4.0.8" - } - }, - "node_modules/@sinonjs/samsam/node_modules/type-detect": { - "version": "4.0.8", - "resolved": "https://registry.npmjs.org/type-detect/-/type-detect-4.0.8.tgz", - "integrity": "sha512-0fr/mIH1dlO+x7TlcMy+bIDqKPsw/70tVyeHW787goQjhmqaZe10uwLujubK9q9Lg6Fiho1KUKDYz0Z7k7g5/g==", - "dev": true, - "engines": { - "node": ">=4" + "type-detect": "^4.1.0" } }, "node_modules/@sinonjs/text-encoding": { - "version": "0.7.2", - "resolved": "https://registry.npmjs.org/@sinonjs/text-encoding/-/text-encoding-0.7.2.tgz", - "integrity": "sha512-sXXKG+uL9IrKqViTtao2Ws6dy0znu9sOaP1di/jKGW1M6VssO8vlpXCQcpZ+jisQ1tTFAC5Jo/EOzFbggBagFQ==", + "version": "0.7.3", + "resolved": "https://registry.npmjs.org/@sinonjs/text-encoding/-/text-encoding-0.7.3.tgz", + "integrity": "sha512-DE427ROAphMQzU4ENbliGYrBSYPXF+TtLg9S8vzeA+OF4ZKzoDdzfL8sxuMUGS/lgRhM6j1URSk9ghf7Xo1tyA==", "dev": true }, "node_modules/@snyk/protect": { - "version": "1.1293.0", - "resolved": "https://registry.npmjs.org/@snyk/protect/-/protect-1.1293.0.tgz", - "integrity": "sha512-k7Xv0lgFskXGjbnhKWmrBNG8d2DHuvEWFu5rVV6ppjDme30nAGn1pvX3XwEeLp9AcovJWjechUOusyNn6S7JKA==", + "version": "1.1293.1", + "resolved": "https://registry.npmjs.org/@snyk/protect/-/protect-1.1293.1.tgz", + "integrity": "sha512-PT2lleyaQU+AvWmnPJ3yKWNyj7JnPUZvOrVTRfXpmmPfjx+U2k3jzsk8EDj0BJd9+goTsTyeQVGCPPSqE5MQtQ==", "dev": true, "bin": { "snyk-protect": "bin/snyk-protect" @@ -804,15 +792,15 @@ "dev": true }, "node_modules/@types/mocha": { - "version": "10.0.7", - "resolved": "https://registry.npmjs.org/@types/mocha/-/mocha-10.0.7.tgz", - "integrity": "sha512-GN8yJ1mNTcFcah/wKEFIJckJx9iJLoMSzWcfRRuxz/Jk+U6KQNnml+etbtxFK8lPjzOw3zp4Ha/kjSst9fsHYw==", + "version": "10.0.8", + "resolved": "https://registry.npmjs.org/@types/mocha/-/mocha-10.0.8.tgz", + "integrity": "sha512-HfMcUmy9hTMJh66VNcmeC9iVErIZJli2bszuXc6julh5YGuRb/W5OnkHjwLNYdFlMis0sY3If5SEAp+PktdJjw==", "dev": true }, "node_modules/@types/node": { - "version": "18.19.47", - "resolved": "https://registry.npmjs.org/@types/node/-/node-18.19.47.tgz", - "integrity": "sha512-1f7dB3BL/bpd9tnDJrrHb66Y+cVrhxSOTGorRNdHwYTUlTay3HuTDPKo9a/4vX9pMQkhYBcAbL4jQdNlhCFP9A==", + "version": "18.19.50", + "resolved": "https://registry.npmjs.org/@types/node/-/node-18.19.50.tgz", + "integrity": "sha512-xonK+NRrMBRtkL1hVCc3G+uXtjh1Al4opBLjqVmipe5ZAaBYWW6cNAiBVZ1BvmkBhep698rP3UM3aRAdSALuhg==", "dev": true, "dependencies": { "undici-types": "~5.26.4" @@ -2199,9 +2187,9 @@ } }, "node_modules/eslint-module-utils": { - "version": "2.8.1", - "resolved": "https://registry.npmjs.org/eslint-module-utils/-/eslint-module-utils-2.8.1.tgz", - "integrity": "sha512-rXDXR3h7cs7dy9RNpUlQf80nX31XWJEyGq1tRMo+6GsO5VmTe4UTwtmonAD4ZkAsrfMVDA2wlGJ3790Ys+D49Q==", + "version": "2.11.0", + "resolved": "https://registry.npmjs.org/eslint-module-utils/-/eslint-module-utils-2.11.0.tgz", + "integrity": "sha512-gbBE5Hitek/oG6MUVj6sFuzEjA/ClzNflVrLovHi/JgLdC7fiN5gLAY1WIPW1a0V5I999MnsrvVrCOGmmVqDBQ==", "dev": true, "dependencies": { "debug": "^3.2.7" @@ -2225,26 +2213,27 @@ } }, "node_modules/eslint-plugin-import": { - "version": "2.29.1", - "resolved": "https://registry.npmjs.org/eslint-plugin-import/-/eslint-plugin-import-2.29.1.tgz", - "integrity": "sha512-BbPC0cuExzhiMo4Ff1BTVwHpjjv28C5R+btTOGaCRC7UEz801up0JadwkeSk5Ued6TG34uaczuVuH6qyy5YUxw==", + "version": "2.30.0", + "resolved": "https://registry.npmjs.org/eslint-plugin-import/-/eslint-plugin-import-2.30.0.tgz", + "integrity": "sha512-/mHNE9jINJfiD2EKkg1BKyPyUk4zdnT54YgbOgfjSakWT5oyX/qQLVNTkehyfpcMxZXMy1zyonZ2v7hZTX43Yw==", "dev": true, "dependencies": { - "array-includes": "^3.1.7", - "array.prototype.findlastindex": "^1.2.3", + "@rtsao/scc": "^1.1.0", + "array-includes": "^3.1.8", + "array.prototype.findlastindex": "^1.2.5", "array.prototype.flat": "^1.3.2", "array.prototype.flatmap": "^1.3.2", "debug": "^3.2.7", "doctrine": "^2.1.0", "eslint-import-resolver-node": "^0.3.9", - "eslint-module-utils": "^2.8.0", - "hasown": "^2.0.0", - "is-core-module": "^2.13.1", + "eslint-module-utils": "^2.9.0", + "hasown": "^2.0.2", + "is-core-module": "^2.15.1", "is-glob": "^4.0.3", "minimatch": "^3.1.2", - "object.fromentries": "^2.0.7", - "object.groupby": "^1.0.1", - "object.values": "^1.1.7", + "object.fromentries": "^2.0.8", + "object.groupby": "^1.0.3", + "object.values": "^1.2.0", "semver": "^6.3.1", "tsconfig-paths": "^3.15.0" }, @@ -3211,9 +3200,9 @@ } }, "node_modules/is-core-module": { - "version": "2.15.0", - "resolved": "https://registry.npmjs.org/is-core-module/-/is-core-module-2.15.0.tgz", - "integrity": "sha512-Dd+Lb2/zvk9SKy1TGCt1wFJFo/MWBPMX5x7KcvLajWTGuomczdQX61PvY5yK6SVACwpoexWo81IfFyoKY2QnTA==", + "version": "2.15.1", + "resolved": "https://registry.npmjs.org/is-core-module/-/is-core-module-2.15.1.tgz", + "integrity": "sha512-z0vtXSwucUJtANQWldhbtbt7BnL0vxiFjIdDLAatwhDYty2bad6s+rijD6Ri4YuYJubLzIJLUidCh09e1djEVQ==", "dev": true, "dependencies": { "hasown": "^2.0.2" @@ -3912,16 +3901,16 @@ "dev": true }, "node_modules/nise": { - "version": "6.0.0", - "resolved": "https://registry.npmjs.org/nise/-/nise-6.0.0.tgz", - "integrity": "sha512-K8ePqo9BFvN31HXwEtTNGzgrPpmvgciDsFz8aztFjt4LqKO/JeFD8tBOeuDiCMXrIl/m1YvfH8auSpxfaD09wg==", + "version": "6.1.1", + "resolved": "https://registry.npmjs.org/nise/-/nise-6.1.1.tgz", + "integrity": "sha512-aMSAzLVY7LyeM60gvBS423nBmIPP+Wy7St7hsb+8/fc1HmeoHJfLO8CKse4u3BtOZvQLJghYPI2i/1WZrEj5/g==", "dev": true, "dependencies": { - "@sinonjs/commons": "^3.0.0", - "@sinonjs/fake-timers": "^11.2.2", - "@sinonjs/text-encoding": "^0.7.2", + "@sinonjs/commons": "^3.0.1", + "@sinonjs/fake-timers": "^13.0.1", + "@sinonjs/text-encoding": "^0.7.3", "just-extend": "^6.2.0", - "path-to-regexp": "^6.2.1" + "path-to-regexp": "^8.1.0" } }, "node_modules/node-preload": { @@ -4436,10 +4425,13 @@ "dev": true }, "node_modules/path-to-regexp": { - "version": "6.2.2", - "resolved": "https://registry.npmjs.org/path-to-regexp/-/path-to-regexp-6.2.2.tgz", - "integrity": "sha512-GQX3SSMokngb36+whdpRXE+3f9V8UzyAorlYvOGx87ufGHehNTn5lCxrKtLyZ4Yl/wEKnNnr98ZzOwwDZV5ogw==", - "dev": true + "version": "8.1.0", + "resolved": "https://registry.npmjs.org/path-to-regexp/-/path-to-regexp-8.1.0.tgz", + "integrity": "sha512-Bqn3vc8CMHty6zuD+tG23s6v2kwxslHEhTj4eYaVKGIEB+YX/2wd0/rgXLFD9G9id9KCtbVy/3ZgmvZjpa0UdQ==", + "dev": true, + "engines": { + "node": ">=16" + } }, "node_modules/path-type": { "version": "4.0.0", @@ -4955,23 +4947,32 @@ "dev": true }, "node_modules/sinon": { - "version": "18.0.0", - "resolved": "https://registry.npmjs.org/sinon/-/sinon-18.0.0.tgz", - "integrity": "sha512-+dXDXzD1sBO6HlmZDd7mXZCR/y5ECiEiGCBSGuFD/kZ0bDTofPYc6JaeGmPSF+1j1MejGUWkORbYOLDyvqCWpA==", + "version": "19.0.2", + "resolved": "https://registry.npmjs.org/sinon/-/sinon-19.0.2.tgz", + "integrity": "sha512-euuToqM+PjO4UgXeLETsfQiuoyPXlqFezr6YZDFwHR3t4qaX0fZUe1MfPMznTL5f8BWrVS89KduLdMUsxFCO6g==", "dev": true, "dependencies": { "@sinonjs/commons": "^3.0.1", - "@sinonjs/fake-timers": "^11.2.2", - "@sinonjs/samsam": "^8.0.0", - "diff": "^5.2.0", - "nise": "^6.0.0", - "supports-color": "^7" + "@sinonjs/fake-timers": "^13.0.2", + "@sinonjs/samsam": "^8.0.1", + "diff": "^7.0.0", + "nise": "^6.1.1", + "supports-color": "^7.2.0" }, "funding": { "type": "opencollective", "url": "https://opencollective.com/sinon" } }, + "node_modules/sinon/node_modules/diff": { + "version": "7.0.0", + "resolved": "https://registry.npmjs.org/diff/-/diff-7.0.0.tgz", + "integrity": "sha512-PJWHUb1RFevKCwaFA9RlG5tCd+FO5iRh9A8HEtkmBH2Li03iJriB6m6JIN4rGz3K3JLawI7/veA1xzRKP6ISBw==", + "dev": true, + "engines": { + "node": ">=0.3.1" + } + }, "node_modules/slash": { "version": "3.0.0", "resolved": "https://registry.npmjs.org/slash/-/slash-3.0.0.tgz", diff --git a/package.json b/package.json index 0b4b07c..ca61ae6 100644 --- a/package.json +++ b/package.json @@ -48,21 +48,21 @@ "CHANGELOG.md" ], "devDependencies": { - "@snyk/protect": "^1.1293.0", - "@types/mocha": "^10.0.7", - "@types/node": "^18.19.47", + "@snyk/protect": "^1.1293.1", + "@types/mocha": "^10.0.8", + "@types/node": "^18.19.50", "@typescript-eslint/eslint-plugin": "^7.18.0", "@typescript-eslint/parser": "^7.18.0", "chai": "^4.5.0", "eslint": "^8.57.0", "eslint-config-airbnb-base": "^15.0.0", "eslint-config-airbnb-typescript": "^18.0.0", - "eslint-plugin-import": "^2.29.1", + "eslint-plugin-import": "^2.30.0", "eslint-plugin-mocha": "^10.5.0", "eslint-plugin-promise": "^7.1.0", "mocha": "^10.7.3", "nyc": "^17.0.0", - "sinon": "^18.0.0", + "sinon": "^19.0.2", "ts-mocha": "^10.0.0", "typescript": "^5.5.4" }, From 7709a80208de40b1b42e1ffdabe8d2ff6aa2a40a Mon Sep 17 00:00:00 2001 From: jshemas Date: Tue, 17 Sep 2024 18:57:22 -0400 Subject: [PATCH 5/6] 6.8.2 --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 7d6ab34..a64e96c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "open-graph-scraper", - "version": "6.8.1", + "version": "6.8.2", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "open-graph-scraper", - "version": "6.8.1", + "version": "6.8.2", "license": "MIT", "dependencies": { "chardet": "^2.0.0", diff --git a/package.json b/package.json index ca61ae6..31c8cf8 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "open-graph-scraper", "description": "Node.js scraper module for Open Graph and Twitter Card info", - "version": "6.8.1", + "version": "6.8.2", "license": "MIT", "main": "./dist/cjs/index.js", "types": "./types/index.d.ts", From 419232f135832d68546b6dc6f2871d636d43e50d Mon Sep 17 00:00:00 2001 From: jshemas Date: Wed, 18 Sep 2024 19:34:38 -0400 Subject: [PATCH 6/6] skip test for now --- tests/integration/basic.spec.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/integration/basic.spec.ts b/tests/integration/basic.spec.ts index ad4ee7b..0af3516 100644 --- a/tests/integration/basic.spec.ts +++ b/tests/integration/basic.spec.ts @@ -465,7 +465,8 @@ describe('basic', function () { }); }); - it('epicgames.com - should return og data using a header', function () { + // todo: this test no longer works in github ci + it.skip('epicgames.com - should return og data using a header', function () { return ogs({ url: 'https://dev.epicgames.com/documentation/ja-jp/unreal-engine/volume-actors-in-unreal-engine', fetchOptions: {