Custom attributes and getUsersForGroup

[magp3]

  attributes: {
         user: ['displayName', 'mail', 'sAMAccountName']
     }

The problem seems to be here: line 70 -
getUsersForGroup.js

At this point u.dn is undefined.
In my case this resulted in only one user from a nested group was returned.

I'm thinking one solution could be to make sure the dn attribute is in
included in the search and then later strip it out of the object added
to the users map to not cause any issues with existing code?

[jsumners]

I believe you are correct. That's what this is supposed to do:

node-activedirectory/lib/components/getUsersForGroup.js

Line 60 in 00ddcfb

utils.pickAttributes(member, this.opts.attributes || ad.defaultAttributes.user)

So I think this will need to be modified to add the dn by default:

node-activedirectory/lib/components/getUsersForGroup.js

Lines 178 to 187 in 00ddcfb

	function getUsersForGroup (opts, groupName, callback) {
	let _opts = opts || {}
	let _groupName = groupName
	let _cb = callback
	if (typeof groupName === 'function') {
	_cb = groupName
	_groupName = opts
	_opts = {}
	}

And then the actual method can be updated to use pickAttributes within the iteration.

Would you like to send a PR?