Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade chartjs to 2.5 #627

Open
3 tasks done
csulok opened this issue Apr 28, 2017 · 3 comments
Open
3 tasks done

upgrade chartjs to 2.5 #627

csulok opened this issue Apr 28, 2017 · 3 comments

Comments

@csulok
Copy link

csulok commented Apr 28, 2017

Overview

angularjs 1.5.11
angular-chart.js 1.1.1
chart.js 2.3.x

When installing the npm package, and building an application with browserify, require will use the chart.js release depended by angular-chart.js, specifically 2.3.x. Can you relax the version dependency to 2.x with a new version, or simply release a new version that depends on 2.5.x? The 2.4 and 2.5 releases of chart.js include important bugfixes I'd like to see in use, e.g.: chartjs/Chart.js#3446

Please make sure to review and check all of these items:

  • Use latest version of the library
  • Make sure you've included all the dependencies e.g Chart.js, angular, etc.
  • Include a repro case, see below.
@AshMartian
Copy link

Is there a fork I can test?

@csulok
Copy link
Author

csulok commented May 25, 2017

Created one #632

@AshMartian
Copy link

AshMartian commented May 25, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants