Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show instance cheat scores on admin dashboard #252

Open
bkimminich opened this issue Oct 5, 2024 · 1 comment
Open

Show instance cheat scores on admin dashboard #252

bkimminich opened this issue Oct 5, 2024 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@bkimminich
Copy link
Member

bkimminich commented Oct 5, 2024

As an admin it would be nice to have the total cheat score per instance visible on the dashboard. This can be retrieved via the Prometheus endpoint /metrics from the juiceshop_cheat_score{app="juiceshop"} field per instance.

⚠️ This would probably solve the "Exposed Metrics" challenge for all instances if pulled from /metrics! The webhook payload also contains the current total cheat score. Other than the challenge status, the cheat score is not available via API/database but on-demand only via Prometheus endpoint.

@bkimminich bkimminich added the enhancement New feature or request label Oct 5, 2024
@J12934
Copy link
Member

J12934 commented Oct 5, 2024

Cool idea :)

It wouldn't need to solve the challenge. We already have a exclusion for requests with a Prometheus user agent. https://github.com/juice-shop/juice-shop/blob/master/routes/metrics.ts#L70

@J12934 J12934 added the help wanted Extra attention is needed label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants