Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone number must be a Singapore number doesn't fit the usage of the app #6

Open
julia-cp opened this issue Apr 19, 2024 · 1 comment

Comments

@julia-cp
Copy link
Owner

julia-cp commented Apr 19, 2024

Actual: only Singapore phone number is valid
Screenshot 2024-04-19 at 5.06.15 PM.png

Expected: can be used for any countries phone number
Screenshot 2024-04-19 at 5.06.50 PM.png

Even if this is only used in Singapore, there are a lot of international people that may not have Singaporean phone number

@nus-se-bot
Copy link

nus-se-bot commented Apr 22, 2024

Team's Response

The target user in this case was actually only for NUS students but we have missed out on adding the this information on the User Guide.
Thanks for pointing that out!

image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

The target user for the product is not specified clearly in the user guide

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.



Expected: UD provide clear specification of the target user
Actual: the target user guide is not specified clearly
Screenshot 2024-04-19 at 5.25.20 PM.png


[original: nus-cs2103-AY2324S2/pe-interim#792] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

❓ Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

  • I disagree

Reason for disagreement: Even though the target users are NUS students, some students do not use Singapore phone numbers.
Exchange students oftentimes don't change their phone numbers and international students sometimes don't change their numbers right away.
So this should be a separate bug from not specifying the target user.


❓ Issue type

Team chose [type.DocumentationBug]
Originally [type.FeatureFlaw]

  • I disagree

Reason for disagreement: Screenshot 2024-04-23 at 6.34.10 PM.png
This issue can be considered as overzealous input validation, especially when it is quite possible that the user will need to enter a non-Singaporean phone number.


❓ Issue severity

Team chose [severity.Low]
Originally [severity.Medium]

  • I disagree

Reason for disagreement: Even though by percentage there are not many students in NUS that don't have Singapore phone numbers, there are quite a lot of students who will interact with these students. Exchange students are also not that rare, we have about 2,300 exchange students from the total number of around 40,000 students. A significant number of students will interact with this population that may not have Singapore phone numbers. Therefore, by considering the target users, other countries' phone numbers should be allowed.

This means this will cause inconveniences to some users. This is not a very rare situation. This is also not a minor inconvenience because the users will not be able to add these phone numbers.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants