Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS][WINDOWS] Difference between pub.dev documentation and project README #795

Open
Johan-Carinus opened this issue Sep 24, 2024 · 1 comment
Labels

Comments

@Johan-Carinus
Copy link

Johan-Carinus commented Sep 24, 2024

Issue

When looking at the README file for the 9.2.1 release tag, it is shown that Windows supports both readAll and deleteAll functions.

https://github.com/mogol/flutter_secure_storage/tree/v9.2.1?tab=readme-ov-file#platform-implementation

This is in contrast with the documentation that is listed for the pub.dev release:

https://github.com/mogol/flutter_secure_storage/tree/v9.2.1/flutter_secure_storage#configure-windows-version

I did a quick check in the Windows release notes and it seems like the readAll and writeAll functions were introduced as far back as flutter_secure_storage_windows 1.1.0

Expected behaviour

The changes in regards to the readAll and writeAll functions should have already been documented in the pub.dev documentation.

Suggested fix

I've opened this PR (#796) to fix the issue.

Copy link

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant