Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor internals to not use params #19

Open
michaels10 opened this issue Oct 4, 2022 · 1 comment
Open

Refactor internals to not use params #19

michaels10 opened this issue Oct 4, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@michaels10
Copy link
Collaborator

Due to the history of MM3, the dictionary params is used as a means of passing around parameters. This is confusing, prone to breakage, and unidiomatic. We should put some time into removing any mention of it in the internal code.

This is a non-trivial undertaking, but it shouldn't be too tricky.

The main pain-point is load_stack, which relies heavily on params and is very common in the code.

The broad-strokes steps are:

  • Make a new version of load_stack that does not rely on params.
  • Make each file use this new version of load_stack
  • Deleteload_stack entirely.
  • Go through each file to remove params dependency
@michaels10 michaels10 added the enhancement New feature or request label Oct 4, 2022
@michaels10
Copy link
Collaborator Author

The big thing holding this back was 'load_stack'. This function was removed -- thus, now it is on any contributors to remove as much of 'params' as possible wherever they can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant