Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbgitpuller cannot pull from github to docker hub image #81

Open
rdmolony opened this issue Oct 15, 2021 · 3 comments
Open

nbgitpuller cannot pull from github to docker hub image #81

rdmolony opened this issue Oct 15, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@rdmolony
Copy link

rdmolony commented Oct 15, 2021

Describe the bug
I'm currently using an environment repo and a content repo as per this discussion and tried your docker hub action to save the environment repo to docker hub.

When running https://mybinder.org/v2/gh/codema-dev/projects-sandbox/main?urlpath=git-pull%3Frepo%3Dhttps%253A%252F%252Fgithub.com%252Fcodema-dev%252Fprojects%26urlpath%3Dlab%252Ftree%252Fprojects%252Fbinder.ipynb%26branch%3Dmain pulling the environment image from docker hub mybinder.org build failed with

image

(see here for more information)

I've reverted back to code used from here before pushing to docker hub and once again it runs fine - https://github.com/codema-dev/projects

To Reproduce
Steps to reproduce the behavior:

  1. Push an environment repo to docker hub by saving this action in .github/workflows.binder.yaml
name: Binder
on: [push]

jobs:
  binder:
    runs-on: ubuntu-latest
    environment: docker
    steps:
    - name: Checkout Code
      uses: actions/checkout@v2
      with:
        ref: ${{ github.event.pull_request.head.sha }}

    - name: update jupyter dependencies with repo2docker
      uses: jupyterhub/repo2docker-action@master
      with:
        DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
        DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
        BINDER_CACHE: true
        PUBLIC_REGISTRY_CHECK: true
  1. Generate a binder link on the environment repo and on the content repo here
  2. Click the binder link

Expected behavior
nbgitpuller pulls from the content repo as expected


Thanks a lot for all your work on this action, Binder has been a life saver in opening up our work to the wider public!

@rdmolony rdmolony added the bug Something isn't working label Oct 15, 2021
@welcome
Copy link

welcome bot commented Oct 15, 2021

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@rdmolony
Copy link
Author

rdmolony commented Oct 15, 2021

Thanks a lot for getting back to me @manics! The main branch works right now as I reverted to a commit without a binder/Dockerfile linking to docker hub - I made a new branch off the failing commit containing the binder/Dockerfile see -
https://mybinder.org/v2/gh/codema-dev/projects-sandbox/revert-to-push-to-docker-hub?urlpath=git-pull%3Frepo%3Dhttps%253A%252F%252Fgithub.com%252Fcodema-dev%252Fprojects%26urlpath%3Dlab%252Ftree%252Fprojects%252Fbinder.ipynb%26branch%3Dmain

(using the amazing nbgitpuller link to generate it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants