Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document and test proxy's soft dependencies #132

Open
2 tasks
GeorgianaElena opened this issue May 10, 2021 · 0 comments
Open
2 tasks

Document and test proxy's soft dependencies #132

GeorgianaElena opened this issue May 10, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@GeorgianaElena
Copy link
Member

The etcd3 and python-consul2 libraries are not installed anymore by default, when installing jupyterhub-traefik-proxy(#127). This libs are only required by the key-value store variants of the proxy, so TomlProxy shouldn't need them (checkout #125 for more context).

We should:

  • Document this
  • Add a test that checks that TomlProxy doesn't require these libraries and works without them (I suspect some refactoring of the testing infrastructure needs to happen before too, because the proxies are a bit "tied together" in the CI)
@GeorgianaElena GeorgianaElena added the enhancement New feature or request label May 10, 2021
@GeorgianaElena GeorgianaElena changed the title Document and test TomlProxy's sof deps (etcd3 & python-consul2) Document and test proxy's soft dependencies May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GeorgianaElena