Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy disable toggle (perhaps via language selector?) #109

Open
athewsey opened this issue Jun 8, 2022 · 1 comment
Open

Easy disable toggle (perhaps via language selector?) #109

athewsey opened this issue Jun 8, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@athewsey
Copy link

athewsey commented Jun 8, 2022

Is your feature request related to a problem? Please describe.

Nice work! I'm just getting started with this extension really, but I notice that while spellchecking in text/markdown file editor is sometimes helpful... Other times I have text-like files (like logs, etc) where the spellcheck highlights are distracting and not really useful.

I think it might be useful to have an easy way to disable spellchecking (whether for the session as a whole or one open file in particular) and then later turn it back on.

Describe the solution you'd like

The first place I looked when coming across this was the language selector button in the bottom toolbar, so for a session-level control I think adding a "disable" option to the dialogue this opens could be a good option? If the toolbar button said something like "Spellchecker Disabled" instead of the selected language when turned off, this could be a good visible reminder for users to turn it back on when needed.

Describe alternatives you've considered

Maybe it'd be more useful in some ways if spellcheck could be disabled for particular open files (to prevent users forgetting and leaving it turned off when later editing notebooks/markdown they cared about)? But I assume this'd be significantly more complex to integrate...

I know there's file MIME type based filtering, but as mentioned the problem is I find spellchecking is sometimes useful for files detected as text/plain and sometimes not.

Additional context

  • Python package version: jupyterlab-spellchecker 0.7.2
  • Extension version: @ijmbarr/jupyterlab_spellchecker v0.7.2 enabled OK (python, jupyterlab-spellchecker)
  • Operating System and its version: Amazon SageMaker Studio, which is running JupyterLab v3.3.0 & Amazon Linux 2

Interested to hear if other people would find this useful too or I just have weird files/workflows 😅

@athewsey athewsey added the enhancement New feature or request label Jun 8, 2022
@krassowski
Copy link
Collaborator

Thanks for the suggestion! I think that this is a good idea. I am happy to review a pull request/help with a draft PR but I would not have time to work on it myself in near future.

@krassowski krassowski added the help wanted Extra attention is needed label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants