Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve string substitution in the worker file #45

Open
jtpio opened this issue Dec 11, 2022 · 1 comment
Open

Improve string substitution in the worker file #45

jtpio opened this issue Dec 11, 2022 · 1 comment

Comments

@jtpio
Copy link
Member

jtpio commented Dec 11, 2022

Currently there is a build step in package.json involving a call to sed to replace a substring:

"sed-worker": "shx sed -i \"s/XEUS_KERNEL_FILE/'.\\/xlua_wasm.js'/\" src/worker.ts && shx sed -i \"s/LANGUAGE_DATA_FILE/''/\" src/worker.ts ",

We should look into making this step more robust.

@JohanMabille
Copy link
Collaborator

A solution suggested by @jtpio is to use handlebars.
Another solution would be to have the ts files generated / confugred by cmake when building the jupyterlite kernels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants