Incorrect Typescript typings

[cryptic-mystic]

Currently using @loona/react for a new project, and running into issues wrt Typescript.

For example the first parameter to patchQuery in Context is typed as a DocumentNode, which only allows for referencing a query with no variables set, which is very limiting. Actual type should be DocumentNode | { query: DocumentNode, variables: any } or something similar.

loona/packages/core/src/types/common.ts

Line 17 in 58e56c1

patchQuery(query: DocumentNode, producer: (data: any) => any): any;

Great library, thanks for all the work on this!

[wtrocki]

@TheCrow1213 Seen the same. Feel free to create PR with the fix.

[cryptic-mystic]

@wtrocki Can do!

[cryptic-mystic]

I'll clone this weekend and submit a PR.

[cryptic-mystic]

Lol I didn't get to it but I will I promise!

[cryptic-mystic]

@wtrocki @kamilkisiela I don't have permissions to push up a branch, but have a small fix ready if ya'll want it.

I have other ideas for extending Typescript support so that Loona better integrates with other tools like graphql codegen, if ya'll are looking for more contributors :)

[wtrocki]

@TheCrow1213 Let's wait for @kamilkisiela reply. I'm also happy to contribute back.
When no response for some time we can fork this repository to some neutral organization like graphql-community and continue to improve it there, while still creating PR's to this repository.

[cryptic-mystic]

I need to move pretty fast in my current project for work, so I think for now I will fork Loona and make the necessary modification myself.

If this project becomes active again and ya'll need contributors hit me up.

[Urigo]

@TheCrow1213 can you share a reproduction? something from your solution? or a failing test?