Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the repository public #84

Closed
12 of 17 tasks
Hespian opened this issue Dec 16, 2021 · 2 comments
Closed
12 of 17 tasks

Make the repository public #84

Hespian opened this issue Dec 16, 2021 · 2 comments
Milestone

Comments

@Hespian
Copy link
Member

Hespian commented Dec 16, 2021

The current plan is to make this repo public once the "Proof of Concept v0.1.0" milestone is finished.

Here is a (probably incomplete) list of thing to before switching to public:

Things that can only be done after switching to public:

  • Add branch protection rules:
    • Disable (force) push to main
    • Require at least one approving review/no review requesting changes before merging
    • Require all checks to pass before merging
    • Require all conversations to be resolved before merging
    • (Maybe) Use "Require linear history" feature
    • (Maybe) Use "Require merge queue" feature - It seems like this will always use fast-forward instead of squash
@Hespian Hespian added this to the Proof of Concept v0.1.0 milestone Dec 16, 2021
@ByteHamster
Copy link
Contributor

Somehow make it impossible to use the self-hosted runner (so nobody can make a malicious pull request that runs on our server)

There is a setting on public repos for this:

grafik

Change merge guidelines (external contributors can't merge themselves)

External contributors can never merge their own PRs. There is not even a setting that would allow that.

@Hespian
Copy link
Member Author

Hespian commented Feb 11, 2022

There is a setting on public repos for this:>

We don't really need that if we use github hosted runner, right? So we should just remove access to our self-hosted runner for the entire repo (or just completely remove the runner form our server - right now kampi dot en ge is the only repo using it.)

External contributors can never merge their own PRs. There is not even a setting that would allow that.

Yes, but the guidelines say that they should merge themselves ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants