Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple test correction options? #23

Closed
MADscientist314 opened this issue Nov 10, 2020 · 2 comments
Closed

multiple test correction options? #23

MADscientist314 opened this issue Nov 10, 2020 · 2 comments
Assignees
Labels

Comments

@MADscientist314
Copy link

Is there anyway to include a padj for multiple test correction using Bonferroni correction or Benjamini-Hochberg procedure?

@karoliskoncevicius
Copy link
Owner

karoliskoncevicius commented Nov 10, 2020

Good question. I have thought about it and decided against including automatic p-value adjustments for two reasons:

  1. While it is true that the package is mostly used in -omics, where the p-values have to be adjusted, it is not the only possible use case. And, based on user feedbacks, the package sometimes ends up being used in quite different circumstances where adjustment doesn't make sense. Like, for example, doing faster simulation-based power analyses.

  2. There are many p-value adjustment methods, each with their own goals, and so one method is not better than the other. This means that the users will have to select the most appropriate adjustment method based on their specific needs.

Luckily, adjusting p-values is very easy in R:

res <- col_waerden(iris[,-5], iris[,5])
res$pbonf <- p.adjust(res$pvalue, "bonferroni")

Let me know if this answers the question.

@MADscientist314
Copy link
Author

Thanks for the feedback and the guidance regarding p adjustment. This package has been super helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants