This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
static-checks: unconvert should run with --all option #4517
Labels
Comments
egernst
added
bug
egernst
added a commit
to egernst/tests
that referenced
this issue
Feb 25, 2022
We've seen instances of casting's being flagged on linux, when they are necessary running on other OSs (Darwin). Let's make sure we run unconvert w. --all to address this. Fixes: kata-containers#4517 Signed-off-by: Eric Ernst <[email protected]>
egernst
added a commit
to egernst/tests
that referenced
this issue
Feb 25, 2022
We've seen instances of casting's being flagged on linux, when they are necessary running on other OSs (Darwin). While unconvert does have an "all" option where it'll check OS/Arch combinations, this isn't exposed in golangci-lint. Let's disable for now. Fixes: kata-containers#4517 Signed-off-by: Eric Ernst <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
currently unconvert static check will fail for some host operating systems, but pass on others. Example, see kata-containers/kata-containers#3774 (comment)
It looks like this isn't supported in golangci-lint at this point: golangci/golangci-lint#1809
Let's drop until golangci-lint supports this.
The text was updated successfully, but these errors were encountered: