Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve doc comments in pkg/reconciler/workload/namespace #35

Open
ncdc opened this issue Mar 14, 2023 · 2 comments
Open

Improve doc comments in pkg/reconciler/workload/namespace #35

ncdc opened this issue Mar 14, 2023 · 2 comments

Comments

@ncdc
Copy link
Member

ncdc commented Mar 14, 2023 

          super-nit: this comment (and a bunch of the others) are mechanistic, but would be more useful if they were semantic - what does it _mean_ to move an annotation from a placement to a label on a synctarget? What's the point of what we're doing here?

Originally posted by @stevekuznetsov in kcp-dev/kcp#2874 (comment)
@ncdc ncdc mentioned this issue Mar 14, 2023
Merged
@mjudeikis
Copy link
Contributor

/transfer-issue contrib-tmc

1 similar comment
@mjudeikis
Copy link
Contributor

/transfer-issue contrib-tmc

@kcp-ci-bot kcp-ci-bot transferred this issue from kcp-dev/kcp Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
kcp
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ncdc @mjudeikis