-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add scaler for Google Cloud Tasks #4834
feat: Add scaler for Google Cloud Tasks #4834
Conversation
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
While you are waiting, make sure to:
Learn more about: |
06da142
to
4f737e4
Compare
Hi @jmalvarezf-lmes Based on how GCP works, majority of the scalers are just copies from others because almost all are based on StackDriver to get information about them, so I don't think that it's a problem. Let us know if you need help with docs or e2e test stuff 😄 |
@JorTurFer Ok will do. I'll start with the e2e test. Do I have to wait till the night to see the result execution? Thank you, |
Signed-off-by: Jose Maria Alvarez <[email protected]>
330e21e
to
97b7d58
Compare
Signed-off-by: Jose Maria Alvarez <[email protected]>
Signed-off-by: Jose Maria Alvarez <[email protected]>
8771c93
to
9312364
Compare
Signed-off-by: Jose Maria Alvarez <[email protected]>
Signed-off-by: Jose Maria Alvarez <[email protected]>
No no, nightly execution is from main, from PRs we can trigger them manually. Do you need to deploy some extra resources in GCP? If yes, you need to spin up them with a PR to this repo: https://github.com/kedacore/testing-infrastructure |
It'd be interesting if we add support (and coverage with e2e tests) for pod identity. Could you take a look to that part too? |
/run-e2e gcp |
@JorTurFer I've seen that the cloud tasks api is not enabled in the project. Does it make sense to add the api enablement here? You haven't had to enable an api before in gcp. Thanks, |
What api do you need? I can enable it later on |
cloudtasks.googleapis.com |
I have just enabled the api: kedacore/testing-infrastructure@20cc3a9 |
/run-e2e gcp |
Ok this didnt fail in my projects because I have app engine enabled. Will
specify the location tomorrow.
Thanks!
El mar, 1 ago 2023, 22:52, Jorge Turrado Ferrero ***@***.***>
escribió:
… APIs are enabled now, but there is still an error:
[image: image]
<https://user-images.githubusercontent.com/36899226/257638296-ed9d4722-018f-44a7-b4cd-bc8f126bb1de.png>
—
Reply to this email directly, view it on GitHub
<#4834 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMM6O7IDMPME567IGEESPI3XTFT4FANCNFSM6AAAAAA26AZDTY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
These are the apis enabled: If you need any other API enabled, just draft a PR adding it to the list and tomorrow I'll merge it 😄 |
Signed-off-by: Jose Maria Alvarez <[email protected]>
/run-e2e gcp |
Signed-off-by: Jose Maria Alvarez <[email protected]>
Signed-off-by: Jose Maria Alvarez <[email protected]>
/run-e2e gcp |
Signed-off-by: Jose Maria Alvarez <[email protected]>
/run-e2e gcp |
/run-e2e gcp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmalvarezf-lmes any update on this please?
Signed-off-by: Jose Maria Alvarez <[email protected]>
Signed-off-by: Jose Maria Alvarez <[email protected]>
Signed-off-by: Jose Maria Alvarez <[email protected]>
Signed-off-by: Jose Maria Alvarez <[email protected]>
Signed-off-by: Jose Maria Alvarez <[email protected]>
Signed-off-by: Jose Maria Alvarez <[email protected]>
now renaming should be done, you can check if it's ok, and then launch e2e tests if so. |
/run-e2e gcp_cloud_tasks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just one nit in changelog
Signed-off-by: Jose Maria Alvarez <[email protected]>
Signed-off-by: Jose Maria Alvarez <[email protected]>
Signed-off-by: Jose Maria Alvarez <[email protected]>
Signed-off-by: Jose Maria Alvarez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmalvarezf-lmes there are some conflicts blocking us from merging this PR, could you please take a look? Thanks!
Signed-off-by: Jose Maria Alvarez Fernandez <[email protected]>
Should be now addressed. |
Signed-off-by: Jose Maria Alvarez <[email protected]>
thanks a lot! ❤️ |
/run-e2e gcp |
* feature: add cloud tasks scaler Signed-off-by: Jose Maria Alvarez <[email protected]> * Add cloud tasks e2e test Signed-off-by: Jose Maria Alvarez <[email protected]> * fix: Return files to the original state Signed-off-by: Jose Maria Alvarez <[email protected]> * fix: static checks Signed-off-by: Jose Maria Alvarez <[email protected]> * fix: more static checks fixed Signed-off-by: Jose Maria Alvarez <[email protected]> * fix: add location for queue Signed-off-by: Jose Maria Alvarez <[email protected]> * fix: add correct command to create test tasks in queue Signed-off-by: Jose Maria Alvarez <[email protected]> * fix: add fixes to test and add pod identity test Signed-off-by: Jose Maria Alvarez <[email protected]> * fix: specify location also in tasks Signed-off-by: Jose Maria Alvarez <[email protected]> * fix: correct indentation and location for purge Signed-off-by: Jose Maria Alvarez <[email protected]> * fix: correct naming, add package correctly to identity tests Signed-off-by: Jose Maria Alvarez <[email protected]> * fix: change test name Signed-off-by: Jose Maria Alvarez <[email protected]> * fix: add gcp as prefix for naming for clarity Signed-off-by: Jose Maria Alvarez <[email protected]> * fix: correct problem in test when changing name in struct Signed-off-by: Jose Maria Alvarez <[email protected]> * fix: order in changelog Signed-off-by: Jose Maria Alvarez <[email protected]> * fix: another order change in changelog Signed-off-by: Jose Maria Alvarez <[email protected]> * fix: more renaming Signed-off-by: Jose Maria Alvarez <[email protected]> * fix: put it in a new section Signed-off-by: Jose Maria Alvarez <[email protected]> * fix: try a new order for the changelog Signed-off-by: Jose Maria Alvarez <[email protected]> * fix: delete unneeded line Signed-off-by: Jose Maria Alvarez <[email protected]> * fix: into the new Changelog section Signed-off-by: Jose Maria Alvarez <[email protected]> * fix: another order fix Signed-off-by: Jose Maria Alvarez <[email protected]> --------- Signed-off-by: Jose Maria Alvarez <[email protected]> Signed-off-by: Jose Maria Alvarez Fernandez <[email protected]> Signed-off-by: anton.lysina <[email protected]>
Hi,
This is a PR to add scaler based on google cloud tasks depth (#3613). I've added basic tests, but before adding e2e tests, I wanted to know if this continues to be interesting.
If so, I will add this, and the docs part.
It is a copy of the structure of pubsub scaler, but much easier as there is only one metric that makes sense when talking about scaling up/down.
Hope it makes sense,
Regards,
Jose Maria.
Fixes: #3613