From 0036bdee488ca506062f71058ff49229120d262b Mon Sep 17 00:00:00 2001 From: Deepyaman Datta Date: Mon, 9 Oct 2023 20:10:45 -0600 Subject: [PATCH] Undo changes to `engines` values type (for Sphinx) --- kedro-datasets/kedro_datasets/pandas/sql_dataset.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/kedro-datasets/kedro_datasets/pandas/sql_dataset.py b/kedro-datasets/kedro_datasets/pandas/sql_dataset.py index cf5483052..31af58d9b 100644 --- a/kedro-datasets/kedro_datasets/pandas/sql_dataset.py +++ b/kedro-datasets/kedro_datasets/pandas/sql_dataset.py @@ -155,8 +155,9 @@ class SQLTableDataset(AbstractDataset[pd.DataFrame, pd.DataFrame]): DEFAULT_LOAD_ARGS: dict[str, Any] = {} DEFAULT_SAVE_ARGS: dict[str, Any] = {"index": False} - - engines: dict[str, Engine] = {} + # using Any because of Sphinx but it should be + # sqlalchemy.engine.Engine or sqlalchemy.engine.base.Engine + engines: dict[str, Any] = {} def __init__( # noqa: PLR0913 self, @@ -377,7 +378,9 @@ class SQLQueryDataset(AbstractDataset[None, pd.DataFrame]): date: "%Y-%m-%d %H:%M:%S.%f0 %z" """ - engines: dict[str, Engine] = {} + # using Any because of Sphinx but it should be + # sqlalchemy.engine.Engine or sqlalchemy.engine.base.Engine + engines: dict[str, Any] = {} def __init__( # noqa: PLR0913 self,