Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(datasets): delay Engine creation until need #366

Closed
deepyaman opened this issue Oct 2, 2023 · 2 comments · Fixed by #281
Closed

perf(datasets): delay Engine creation until need #366

deepyaman opened this issue Oct 2, 2023 · 2 comments · Fixed by #281
Assignees

Comments

@deepyaman
Copy link
Member

Description

Context

See kedro-org/kedro#2829

Possible Implementation

#281

Possible Alternatives

@astrojuanlu
Copy link
Member

For context, this is a proposed solution for the problem stated in kedro-org/kedro#2829, but I'm not sure there was consensus there, or enough exploration of the solution space cc @merelcht

@deepyaman
Copy link
Member Author

For context, this is a proposed solution for the problem stated in kedro-org/kedro#2829, but I'm not sure there was consensus there, or enough exploration of the solution space cc @merelcht

We had a discussion regarding this, that this is not a solution for kedro-org/kedro#2829 as the OP has stated it (where you don't want to have to provide any connection string at all; hence, I unassigned myself from that broader issue), but that it's an improvement nonetheless (i.e. there's no reason to create the connection well before you're actually going to use it, if at all).

@stichbury stichbury transferred this issue from kedro-org/kedro Oct 3, 2023
@deepyaman deepyaman moved this from To Do to In Progress in Kedro Framework Oct 6, 2023
@deepyaman deepyaman moved this from In Progress to In Review in Kedro Framework Oct 13, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants