-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kedro-datasets: allow skipping Python 3.12 unit tests for SnowflakeTableDatasets #890
Comments
Hi @tdhooghe, thanks for opening this issue. We're more than happy to accept a contribution to make this work if you have an idea! |
Hi @merelcht, thank you for your response :) Currently, SnowflakeTableDatasets are not included in testing (see here), because it needs a dedicated instance of Snowflake running (see here). Happy to keep it this way and merge #881, and bumping the In the future, I would also be happy to include this testing framework, instead of the way it is currently setup. |
Hi @tdhooghe that sounds good to me. I was actually thinking we probably need to demote this dataset to experimental, since it doesn't technically adhere to our requirements of testing and python version support. Of course, if the testing framework you linked works fine, we can then make it a core dataset again. |
Hmm makes sense, although I think it would be really nice to have this one as core dataset.. If I implement the testing framework above, would the team then be fine of not having compatibility with Python 3.12 (for now, and once it is there, I will make the PR for including)? |
Done in #881 |
Description
Currently, installing testing requirements are failing for SnowflakeTableDatasets for Python 3.12, because it is not supported yet by the SnowparkAPI... Skipping Python 3.12 makes the tests succeed, as shown here
Context
I want to create a PR (#881) for SnowflakeTableDatasets, and the unit testing is failing.
Possible Implementation
Update CI/CD in such a way that it can skip unit tests for Python 3.12
Possible Alternatives
The text was updated successfully, but these errors were encountered: