Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A null property_value isn't allowed in Filter #95

Open
masojus opened this issue Apr 14, 2017 · 0 comments
Open

A null property_value isn't allowed in Filter #95

masojus opened this issue Apr 14, 2017 · 0 comments

Comments

@masojus
Copy link
Collaborator

masojus commented Apr 14, 2017

Since the API does allow for a given property to be null and pass an exists filter with a value of true, and of course a property can have the string value 'null', there is a meaningful distinction here that needs to be addressed.

See here where we can fix this and add tests.

Note that the .NET SDK has the same bug.

We could be more explicit about which filters are actually nullable and proactively warn client code with exceptions if trying to, say, set the property_value to null for an exists filter when only true and false are acceptable values. However, we don't do any of that type of validation right now on the Filter.propertyValue so that might be out of scope, and at a minimum we should accept null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant