Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minutes and resolveAfterMinutes data type #10

Open
mnkg561 opened this issue Aug 17, 2021 · 0 comments
Open

Minutes and resolveAfterMinutes data type #10

mnkg561 opened this issue Aug 17, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@mnkg561
Copy link
Collaborator

mnkg561 commented Aug 17, 2021

Is this a BUG REPORT or FEATURE REQUEST?:
Feature

What happened:
Minutes and resolveAfterMinutes are declared as int since wavefront allows only integer values. This should be fine for single alert creation but if users wants to use go lang template to variablize based on the requirements kubectl or open api will throw an error since go lang template {{ .foo }} is a string and not an integer.

Allow Minutes and resolveAfterMinutes as custom data type StringOrInt? - May be, depends on the requirement we can figure it out

What you expected to happen:
Minutes and resolveAfterMinutes can also parameterized using Go Lang template with AlertsConfig supplying the data

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • alert-manager version
  • Kubernetes version :
$ kubectl version -o yaml

Other debugging information (if applicable):

- controller logs:

$ kubectl logs

@mnkg561 mnkg561 added the enhancement New feature or request label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant