Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade-manager-v2: Delete old rollups upon upgrade-manager start. #268

Open
shreyas-badiger opened this issue Jun 24, 2021 · 1 comment

Comments

@shreyas-badiger
Copy link
Collaborator

Everytime upgrade-manager starts, it must delete all the previous rollups.

@shrinandj
Copy link
Collaborator

Deleting all rolling-upgrades upon controller restarts could be dangerous. This should be done at least via a config option. If a particular rolling-upgrade object is causing the controller to crash and restart, there is value is keeping the rolling-upgrade object around for debugging purposes.

Another option (and maybe inline with other Kubernetes objects) is to have a ttlAfterCompletion value in each rolling-upgrade object. The controller should run a GC task periodically and clean up all rolling-upgrade objects if their ttlAfterCompletion has passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants