From ec0febb778d237826f6753d75dc23edd9ef6bd20 Mon Sep 17 00:00:00 2001 From: Keith Turner Date: Mon, 30 Sep 2024 17:06:07 +0000 Subject: [PATCH] more cleanup --- .../apache/accumulo/core/client/rfile/LoadPlanCollector.java | 1 - .../org/apache/accumulo/core/client/rfile/RFileWriter.java | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/core/src/main/java/org/apache/accumulo/core/client/rfile/LoadPlanCollector.java b/core/src/main/java/org/apache/accumulo/core/client/rfile/LoadPlanCollector.java index 6c7263dcacc..1ee4c8b7133 100644 --- a/core/src/main/java/org/apache/accumulo/core/client/rfile/LoadPlanCollector.java +++ b/core/src/main/java/org/apache/accumulo/core/client/rfile/LoadPlanCollector.java @@ -71,7 +71,6 @@ private void appendSplits(Key key) { var extent = new KeyExtent(FAKE_ID, tableSplits.getEndRow(), tableSplits.getPrevRow()); Preconditions.checkState(extent.contains(row), "%s does not contain %s", tableSplits, row); if (currentExtent != null) { - // TODO validate that row is after the currentExtent overlappingExtents.add(currentExtent); } currentExtent = extent; diff --git a/core/src/main/java/org/apache/accumulo/core/client/rfile/RFileWriter.java b/core/src/main/java/org/apache/accumulo/core/client/rfile/RFileWriter.java index c40bb0894e5..8ef0863be63 100644 --- a/core/src/main/java/org/apache/accumulo/core/client/rfile/RFileWriter.java +++ b/core/src/main/java/org/apache/accumulo/core/client/rfile/RFileWriter.java @@ -272,9 +272,8 @@ public void close() throws IOException { * @param filename * @return load plan computed from the keys written to the rfile. * @see org.apache.accumulo.core.client.rfile.RFile.WriterOptions#withSplitResolver(LoadPlan.SplitResolver) - * TODO since tags on all new apis + * @since 2.1.4 */ - // TODO test case of empty rfile... and just test this in general public LoadPlan getLoadPlan(String filename) { return loadPlanCollector.getLoadPlan(filename); }