Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember.Logger deprecation #113

Open
Ralica opened this issue Feb 15, 2023 · 1 comment · May be fixed by #116
Open

Ember.Logger deprecation #113

Ralica opened this issue Feb 15, 2023 · 1 comment · May be fixed by #116

Comments

@Ralica
Copy link

Ralica commented Feb 15, 2023

Hello,
range-slider.js is making use of Ember.Logger but this class is now deprecated. (https://rfcs.emberjs.com/id/0297-deprecate-ember-logger/)
As per the deprecation doc console.warn() can be used instead of the logger warn method.
Would you accept a contribution so that I could keep using this addon with out upgraded Ember project? We just upgraded to ember 4.10 and this seems to be the only issue I find which prevents the addon from continuing to be useful.

Thanks,
Ralica

@derrabauke derrabauke linked a pull request Sep 27, 2023 that will close this issue
@derrabauke
Copy link

Hey @Ralica,

you could fork the repository and fix it there. I did just the same here. And then reference it in your package json via
"ember-cli-nouislider": "derrabauke/ember-cli-nouislider#cf0d87986cf25d5795e1edd6c8b9f008c5b39872",

Nevertheless I've picked up your idea and created a PR #116 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants