Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare where frequently used arguments for Maestro Jobs should be stored #773

Open
pawiecz opened this issue Sep 2, 2024 · 0 comments
Open
Labels
techdebt Something that works for now, but should be done better

Comments

@pawiecz
Copy link
Contributor

pawiecz commented Sep 2, 2024

Many Maestro Jobs definitions are Jinja2 templates that are rendered before being submitted to a relevant Runtime. They can be adjusted by setting arguments in e.g.

  1. pipeline.yaml configuration file, section: jobs: $JOB: params: $PARAM: $ARG
  2. template: {%- set $PARAM = '$ARG' %}

One of the recent PRs dropped the template approach if the only parameter changed was the test_method. After merging #705 there might be a need to reuse this approach for Tast/Fluster jobs as well.

There was an attempt to do so in one of the revisions of #705 but it was eventually reverted (templates can have only a single {% extends %}, other common sections could use e.g. {% includes %}).

@pawiecz pawiecz added the techdebt Something that works for now, but should be done better label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
techdebt Something that works for now, but should be done better
Projects
None yet
Development

No branches or pull requests

1 participant